darcs

Patch 1651 fix ugly code layout for data Simple (and 8 more)

Title fix ugly code layout for data Simple (and 8 more)
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone

Created on 2018-02-22.13:13:32 by bf, last changed 2018-03-23.15:39:38 by gh.

Files
File name Status Uploaded Type Edit Remove
fix-ugly-code-layout-for-data-simple.dpatch bf, 2018-02-22.13:13:27 text/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg19911 (view) Author: bf Date: 2018-02-22.13:13:27
Assorted minor cleanups and refactorings that came up lately. These
should all be uncontroversial.

9 patches for repository http://darcs.net/screened:

patch fafa1bd5daa094e23a9e8be47389e53714081758
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Feb 15 09:47:59 CET 2018
  * fix ugly code layout for data Simple

patch 4ed7ca0e33caaf4f7e3f42f5994c3fe2428ba529
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Feb 15 10:00:34 CET 2018
  * fix ugly layout of data FilePatchType

patch f02a51607d20219e29d5123f5773980f84e37d28
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Thu Feb 15 17:04:10 CET 2018
  * remove redundant seq calls in D.P.Prim.V1.Commute
  
  All fields of type FileName are already marked as strict fields.

patch a5731cc96e7a077c6a6d23ed2dc97f64bf9b780f
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Thu Feb 15 17:28:30 CET 2018
  * refactored commutation of hunks
  
  The new version is much more readable IMO.

patch c3f6ef0a86af8b306e715bb91a24f808ed11983f
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Feb 18 17:05:16 CET 2018
  * cleanup: break overlong lines in D.UI.SelectChanges

patch 80d4350681ad4d29db210fe42e9ede44ca2855f3
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Feb 17 14:15:29 CET 2018
  * fix a trivial haddock syntax error

patch 15d889893ec3e407d8491684f4ff915822c92de5
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Feb 20 23:05:25 CET 2018
  * removed nowhere used mReadFilePSs, mModifyFilePSs

patch 28acc6de314beb513a40a2d2c403bc91f3e1f4f3
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Feb 20 23:08:16 CET 2018
  * reformat an import list in Darcs.Patch.ApplyMonad

patch 26971199d11154097b0604afca03f88e996a34ae
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Feb 21 03:52:39 CET 2018
  * simplified Darcs.Util.ByteString.breakAfterNthNewline
Attachments
msg20006 (view) Author: gh Date: 2018-03-23.15:39:37
The following are trivial and fine:

  * fix ugly code layout for data Simple
  * fix ugly layout of data FilePatchType
  * cleanup: break overlong lines in D.UI.SelectChanges
  * fix a trivial haddock syntax error
  * reformat an import list in Darcs.Patch.ApplyMonad

The following are correct:

* remove redundant seq calls in D.P.Prim.V1.Commute
  All fields of type FileName are already marked as strict fields.
* refactored commutation of hunks
* removed nowhere used mReadFilePSs, mModifyFilePSs
* simplified Darcs.Util.ByteString.breakAfterNthNewline
  
Accepted.
History
Date User Action Args
2018-02-22 13:13:32bfcreate
2018-03-07 00:36:15bfsetstatus: needs-screening -> needs-review
2018-03-23 15:39:38ghsetstatus: needs-review -> accepted
messages: + msg20006