Patch 1658: resolve issue2569: decoding multibyte characters - Darcs bug tracker

Title	resolve issue2569: decoding multibyte characters
Superseder		Nosy List
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2018-03-04.17:25:41 by bfrk, last changed 2018-03-23.14:47:23 by gh.

Files
File name	Status	Uploaded	Type	Edit	Remove
resolve-issue2569_-decoding-multibyte-characters.dpatch		bfrk, 2018-03-04.17:25:41	application/x-darcs-patch

See mailing list archives for discussion on individual patches.

Messages
msg19935 (view)	Author: bfrk	Date: 2018-03-04.18:07:19
All tests are passing here.
msg19967 (view)	Author: gh	Date: 2018-03-14.13:52:25
Does this mean that encoding issues are fixed also on Windows?
msg19979 (view)	Author: bfrk	Date: 2018-03-17.19:50:16
It might help solving the windows issues. Ganesh?
msg19981 (view)	Author: ganesh	Date: 2018-03-18.14:42:08
Sorry, haven't had time to double-check yet, but I had an initial play when the patch first arrived and I don't think it does. I need to get the other Windows build fixes cleaned up/submitted so I have an easier baseline to work with.
msg20005 (view)	Author: gh	Date: 2018-03-23.14:47:23
The patch refers to http://bugs.darcs.net/issue2569 , in that there is a problem with decoding multibyte characters inside of strings of size bigger than 4096 bytes. The patch reemoves the dependenccy on the 'knob' package. Ben's comments about not needing knob are: * http://bugs.darcs.net/msg19931 * http://bugs.darcs.net/msg19932 The patch also modifies the QuickCheck test propDecodeThenEncodeRoundTrip by removing the 4096 bytes limit guard. And of course it modifies Darcs.Util.Encoding to stop using knob. I did not dive into the details of why knob would be useless but I trust the new QuickCheck property to catch bugs if there are. Accepted.

History
Date	User	Action	Args
2018-03-04 17:25:41	bfrk	create
2018-03-04 18:07:19	bfrk	set	status: needs-screening -> needs-review messages: + msg19935
2018-03-14 13:52:25	gh	set	messages: + msg19967
2018-03-17 19:50:16	bfrk	set	messages: + msg19979
2018-03-18 14:42:08	ganesh	set	messages: + msg19981
2018-03-23 14:47:23	gh	set	status: needs-review -> accepted messages: + msg20005