darcs

Patch 1659 several improvements to the test suite (unit tests)

Title several improvements to the test suite (unit tests)
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone

Created on 2018-03-07.01:20:39 by bf, last changed 2018-03-24.14:14:50 by bf.

Files
File name Status Uploaded Type Edit Remove
darcs_cabal_-clean-up-alignment.dpatch bf, 2018-03-07.01:34:39 application/x-darcs-patch
harness_-add-option-__full-to-run-all-tests-in-all-variants.dpatch bf, 2018-03-07.01:20:39 application/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg19946 (view) Author: bf Date: 2018-03-07.01:20:39
These improvements to the test suite are part of the fall-out from my
ongoing work on HunkMove patches.

11 patches for repository http://darcs.net/screened:

patch 76a61d1224dbb6131605478e66520083f156de7d
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Feb 26 00:21:01 CET 2018
  * harness: add option --full to run all tests in all variants

patch ae64b8708bad6d1ab40f4c3272afff1026501051
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Mar  7 01:41:21 CET 2018
  * fix in harness: show_read tested the wrong thing

patch ddbd2cb6e921f3c85293ae3698e8f01ae8778742
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Feb 25 13:53:18 CET 2018
  * harness: improve reports when properties fail
  
  Also broke some overlong lines and fixed a few comments.

patch 4ad784acc923179115663e425a673e3908615936
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Feb 26 12:13:20 CET 2018
  * harness: improve output of patchAndInverseCommute

patch efca068fa93a0e225df67e2c61206f49ac0f7aba
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Feb 28 13:27:04 CET 2018
  * harness: code layout for property partialPermutivity

patch 37f577b11564c9410fac4bc5d7a54fbc1addfc8c
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Mar  1 20:50:28 CET 2018
  * darcs.cabal: clean up alignment

patch 9c59321cdddff67e00bd4b1468667e9b32637385
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Feb 27 23:23:17 CET 2018
  * harness: better output when property effectPreserving fails

patch cf597f82a81d46f3a6d8224322ad62b036383a20
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Mar  7 02:08:01 CET 2018
  * harness: minor improvements and cleanups in generic properties

patch ff5a0f65bb056eca778469f071b7ae60995b766c
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Thu Feb 22 17:40:20 CET 2018
  * add tests for linesPS and unlinesPS, move properties from harnes to src

patch 85bc2726699a442813646a5a7c7f45460eba9133
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Feb 28 12:12:03 CET 2018
  * cleanup of code layout and haddocks in D.T.U.TestResult

patch 752a81cb1f26d1ffb440adaefb3049599f5f8d8d
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Feb 28 13:26:37 CET 2018
  * harness: add instance Check p => Check (p:>p)
Attachments
msg19947 (view) Author: bf Date: 2018-03-07.01:34:39
Added a small follow-up that adds version boundaries for pretty-show.
Attachments
msg19948 (view) Author: bf Date: 2018-03-07.01:52:44
Screening them immediately since they are test-suite only.
msg19998 (view) Author: gh Date: 2018-03-22.18:21:24
* harness: add option --full to run all tests in all variants

OK, nice.


  * fix in harness: show_read tested the wrong thing

Indeed. The idea of show_read is interating with the filesystem, not
with what the user sees.


  * harness: improve reports when properties fail


More detailed output on some tests failure, OK.


  * harness: improve output of patchAndInverseCommute

Slight improvement in output in case of failure, OK.

  * harness: code layout for property partialPermutivity

OK

  * darcs.cabal: clean up alignment

Mkay... that was not super necessary and will not commute with
many other patches in screened but well, that's it. OK.


  * harness: better output when property effectPreserving fails

Here comes the famous pretty-show dependency which you later remove in
a future patch.
There is also the introduction of flattenTree which uses Tree.list to
yield a flat representation of a Tree. Looks good.

  * darcs.cabal: add version limits for pretty-show
  
OK

  * harness: minor improvements and cleanups in generic properties

The call to commuteFLorComplain is replaced by commuteFL, which is almost
the same (see Darcs.Path.Commute). OK.

  * add tests for linesPS and unlinesPS, move properties from harnes to src

OK

  * cleanup of code layout and haddocks in D.T.U.TestResult

OK

  * harness: add instance Check p => Check (p:>p)

OK
  
Acceted
msg20016 (view) Author: bf Date: 2018-03-24.14:14:50
>  * darcs.cabal: clean up alignment
>
>Mkay... that was not super necessary and will not commute with
>many other patches in screened but well, that's it. OK.

True on both accounts. There is a (weak) objective rationale though: you
can now cut and paste (and compare) blocks (multiple lines, e.g.
build-dependencies) between the different sections.
History
Date User Action Args
2018-03-07 01:20:39bfcreate
2018-03-07 01:34:39bfsetfiles: + darcs_cabal_-clean-up-alignment.dpatch
messages: + msg19947
2018-03-07 01:52:44bfsetstatus: needs-screening -> needs-review
messages: + msg19948
2018-03-22 18:21:25ghsetstatus: needs-review -> accepted
messages: + msg19998
2018-03-24 14:14:50bfsetmessages: + msg20016