Patch 1675 stop supporting SHA1-hashed files

Title stop supporting SHA1-hashed files
Superseder Nosy List gh
Related Issues
Status accepted Assigned To

Created on 2018-03-28.19:07:14 by gh, last changed 2018-04-04.12:57:58 by gh.

File name Status Uploaded Type Edit Remove
stop-supporting-sha1_hashed-files.dpatch gh, 2018-03-28.19:07:14 application/octet-stream
stop-supporting-sha1_hashed-repository-files.dpatch gh, 2018-03-29.14:21:02 application/octet-stream
See mailing list archives for discussion on individual patches.
msg20069 (view) Author: gh Date: 2018-03-28.19:07:14

* https://lists.osuosl.org/pipermail/darcs-devel/2018-March/018753.html
* https://irclog.perlgeek.de/darcs/2018-03-28#i_15976226

patch b7234d50814061309ec559cfcb63c346512f9895
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Wed Mar 28 16:03:40 -03 2018
  * stop supporting SHA1-hashed files
  Hashed repos were internally hashed with SHA1 for a short amount of
  time by unreleased Darcs versions before Darcs 2 (in 2008). We drop
  the ability to read them, so that the current code makes more sense.
  Now SHA1 only exists in Darcs to hash patch infos. The testsuite is
  adapted because two repos tarballs are internally hashed with SHA1.
msg20071 (view) Author: bf Date: 2018-03-28.23:23:22
Hmm, "unreleased Darcs versions before Darcs 2" really sounds like we
don't need to support that any longer.

But note that SHA1 is used for two other purposes besides hashing patch
meta data: (1) for patch bundles and (2) in the patch index.
msg20073 (view) Author: gh Date: 2018-03-29.14:19:50
> But note that SHA1 is used for two other purposes besides hashing patch
> meta data: (1) for patch bundles and (2) in the patch index.

* (1) Indeed, I forgot about that one (in Darcs.Patch.Bundle ) so I
should change this patch's name and description

* (2) is the very same hash of patch infos.
msg20074 (view) Author: gh Date: 2018-03-29.14:21:02
Here is the updated patch, I also changed back the constructor for the
SHA1 type from SHA1_ to SHA1 (we no longer need to avoid name collision
in Darcs.Util.Hash).
msg20107 (view) Author: gh Date: 2018-04-04.12:57:58
Date User Action Args
2018-03-28 19:07:14ghcreate
2018-03-28 23:23:23bfsetmessages: + msg20071
2018-03-29 14:19:51ghsetmessages: + msg20073
2018-03-29 14:21:02ghsetfiles: + stop-supporting-sha1_hashed-repository-files.dpatch
messages: + msg20074
2018-03-30 16:29:13ghsetstatus: needs-screening -> needs-review
2018-04-04 12:57:58ghsetstatus: needs-review -> accepted
messages: + msg20107