darcs

Patch 1677 three easy cleanup patches from Ben's branch

Title three easy cleanup patches from Ben's branch
Superseder Nosy List gh
Related Issues
Status accepted Assigned To
Milestone

Created on 2018-03-29.15:46:33 by gh, last changed 2018-03-29.15:49:05 by gh.

Files
File name Status Uploaded Type Edit Remove
remove-several-unused-exports-of-d_r_hashed.dpatch gh, 2018-03-29.15:46:24 application/octet-stream
See mailing list archives for discussion on individual patches.
Messages
msg20080 (view) Author: gh Date: 2018-03-29.15:46:24
Taken from Ben's branch [1] https://hub.darcs.net/bf/darcs-bf-latest,
these 3 patches are:

patch bf74a4df211e7398e5cfe9846203fa447bc2ea77
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Mar 27 15:25:21 -03 2018
  * remove several unused exports of D.R.Hashed
  
  addToSpecificInventory is particularly dangerous, since it doesn't update
  the witnesses of the repo. Its only use is in addToTentativeInventory
which
  is similarly dangerous and unfortunately is used (in convert import);
it now
  has haddocks which warn about that.

patch 14d714b67355f87a7ed55dbd126cae0554baaecc
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Feb 25 09:40:58 -03 2018
  * cleanup: rename x to fmt in D.P.Prim.V1.Show

patch 2c9ffa9cf98137aa8c0aebb003a94984adb6bd76
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Oct 22 07:23:24 -03 2017
  * move makeFilename and readPatchInfos to D.R.Old
  
  These functions are only used to read old-fashioned (non-hashed) repos.
  Concentrating them inside Darcs.Repository.Old (particularly makeFilename)
  makes it clear that they only exist for compatibility and not to be used
  elsewhere.

[1] https://lists.osuosl.org/pipermail/darcs-users/2018-March/027312.html
Attachments
msg20081 (view) Author: gh Date: 2018-03-29.15:49:02
These ones are trivial:

* remove several unused exports of D.R.Hashed
* cleanup: rename x to fmt in D.P.Prim.V1.Show

The following indeed moves functions that are only relevant for
old-fashioned repositories, so the code makes more sense:


* move makeFilename and readPatchInfos to D.R.Old


Accepted.
History
Date User Action Args
2018-03-29 15:46:33ghcreate
2018-03-29 15:49:05ghsetstatus: needs-review -> accepted
messages: + msg20081