darcs

Patch 1678 five test-related patches from Ben's branch

Title five test-related patches from Ben's branch
Superseder Nosy List gh
Related Issues
Status accepted Assigned To
Milestone

Created on 2018-03-29.15:52:37 by gh, last changed 2018-03-29.16:05:06 by gh.

Files
File name Status Uploaded Type Edit Remove
tests_-fix-add_sh-that-created-repos-directly-in-_tmp.dpatch gh, 2018-03-29.15:52:36 application/octet-stream
See mailing list archives for discussion on individual patches.
Messages
msg20082 (view) Author: gh Date: 2018-03-29.15:52:36
Pulled from Ben's branch [1] https://hub.darcs.net/bf/darcs-bf-latest,
the patches are:

5 patches for repository http://darcs.net/reviewed:

patch 526a77dd052dd61d30817d1767cf63d6ce8985be
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Feb 25 20:41:09 -03 2018
  * tests: fix add.sh that created repos directly in /tmp

patch a45cda40ec3fe4dfdae56b0869f2bdb229846e82
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Feb 25 20:42:39 -03 2018
  * tests/network: bake process id into REMOTE_DIR
  
  This allows to run the network tests in parallel.

patch 0122d32b97e00887b1d7dcd2ae5c2d5d383098da
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Wed Mar 28 14:17:07 -03 2018
  * allow shell tests to run in parallel when using --myers and --patience
  
  Like with --darcs1 and --darcs2, we build this option into the path where
  the test is run.

patch 8d9dbb8e1f28538d565b1aad96d8b4342103d6b6
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Wed Mar 28 14:18:40 -03 2018
  * allow running the diff.sh test in parallel
  
  We use our own temporary directory for each test to avoid spurious
differences
  between outputs of 'darcs diff' due to temporary names being already
taken.

patch 25b869593f41251c830c13742e5ef564077633bd
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Wed Mar 28 14:55:44 -03 2018
  * make spurious failures of hashed storage tests less likely
  
  This is not a complete fix, as I am still seeing occasional failures
  ("harness/hstestdata.zip: openBinaryFile: does not exist").



[1] https://lists.osuosl.org/pipermail/darcs-users/2018-March/027312.html
Attachments
msg20083 (view) Author: gh Date: 2018-03-29.16:05:06
* tests: fix add.sh that created repos directly in /tmp

Doesn't actually fix of add.sh (only a slight improvement in the script)
but does fix apply.sh that wrongfully had an extra "cd .." .

* tests/network: bake process id into REMOTE_DIR

OK

* allow shell tests to run in parallel when using --myers and --patience

It allows running them in parallel by putting the diff algorithm name
into the temp directories; OK.

* allow running the diff.sh test in parallel

OK

* make spurious failures of hashed storage tests less likely

It uses Darcs.Util.Lock.withTempDir to do so, which is also a code
improvement. OK
History
Date User Action Args
2018-03-29 15:52:37ghcreate
2018-03-29 16:05:06ghsetstatus: needs-review -> accepted
messages: + msg20083