darcs

Patch 1690 require GHC 8.2, Cabal 2.2 and directory 1.2.7

Title require GHC 8.2, Cabal 2.2 and directory 1.2.7
Superseder Nosy List gh
Related Issues
Status accepted Assigned To
Milestone

Created on 2018-04-06.19:28:56 by gh, last changed 2018-06-24.07:37:12 by ganesh.

Files
File name Status Uploaded Type Edit Remove
re_added-autogen_modules-entries-in-darcs_cabal.dpatch bfrk, 2018-04-19.12:18:32 application/octet-stream
require-directory-1_2_7-and-use-doespathexist.dpatch gh, 2018-04-06.19:28:55 application/octet-stream
See mailing list archives for discussion on individual patches.
Messages
msg20113 (view) Author: gh Date: 2018-04-06.19:28:55
Post-release retro-compatibility liberation, yay!

Following this mail thread [1], here is a patch that requires GHC 8.2
and Cabal 2.2. Some changes are weird (Putting the cabal version as the
first line of darcs.cabal) but they are required by the library. See
https://hackage.haskell.org/package/Cabal-2.2.0.1/changelog  for more
information. Cabal developers say a 3.0 version is planned for mid-2018
so it does not seem too strict to me to require Cabal 2.2 instead of 2.0.

The second patch reverts a dependency changes on directory that we had
to do before the 2.14 release.

2 patches for repository http://darcs.net:

patch 2a6acf4563bec0f3df8ddaa95528987bc2168639
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Fri Apr  6 16:17:09 -03 2018
  * require directory 1.2.7 and use doesPathExist

patch 887c67e5d7a901ab3a93d29ab17f8d91b7faa456
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Fri Apr  6 16:18:27 -03 2018
  * require GHC 8.2 and Cabal 2.2



[1] https://lists.osuosl.org/pipermail/darcs-devel/2018-March/018663.html
Attachments
msg20114 (view) Author: gh Date: 2018-04-09.15:44:15
If nobody is opposed, I am going to screen this bundle tomorrow.
msg20115 (view) Author: ganesh Date: 2018-04-09.17:27:28
I support moving forward with this - I think it's relatively likely 
we'll discover issues with being on the Cabal bleeding edge as we try 
to use it in anger, but we can always roll back some or all of the 
changes as we run into problems.
msg20121 (view) Author: bfrk Date: 2018-04-19.12:13:39
I have added another bundle that rolls back the rollback of the addition
of the autogen-modules fields, to make cabal new-build work.
msg20122 (view) Author: bfrk Date: 2018-04-19.12:18:32
Oops, I've hit "Submit Changes" instead of "Browse..."

1 patch for repository http://darcs.net/screened:

patch 5b9149a1f96ac298e3f917f1c5394f0d3c2af3f7
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Thu Apr 19 14:00:31 CEST 2018
  * re-added autogen-modules entries in darcs.cabal
Attachments
msg20150 (view) Author: ganesh Date: 2018-06-10.14:44:54
I think these are all the right thing to do, accepting.
History
Date User Action Args
2018-04-06 19:28:56ghcreate
2018-04-09 15:44:16ghsetmessages: + msg20114
2018-04-09 17:27:29ganeshsetmessages: + msg20115
2018-04-10 12:30:11ghsetstatus: needs-screening -> needs-review
2018-04-19 12:13:39bfrksetmessages: + msg20121
2018-04-19 12:18:32bfrksetfiles: + re_added-autogen_modules-entries-in-darcs_cabal.dpatch
messages: + msg20122
2018-06-10 14:44:55ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg20150
2018-06-24 07:37:12ganeshsetstatus: accepted-pending-tests -> accepted