darcs

Patch 1703 random selection of small and mostly trivial refactors and fixes

Title random selection of small and mostly trivial refactors and fixes
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone

Created on 2018-07-17.16:03:16 by bf, last changed 2018-07-24.01:09:00 by ganesh.

Files
File name Status Uploaded Type Edit Remove
remove-method-anidentity-from-primconstruct.dpatch bf, 2018-07-17.16:03:15 text/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg20197 (view) Author: bf Date: 2018-07-17.16:03:15
As the title says, these are all small or at least semantically trivial
changes. Except perhaps the first patch, but this one has all the
interesting changes in the test harness.

11 patches for repository http://darcs.net/screened:

patch 1c00e6b62cb0515b3c193b4e6e5685811d997798
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue May  1 17:41:24 CEST 2018
  * remove method anIdentity from PrimConstruct
  
  This method was used only in the test harness to extract pairs and triples
  of adjacent patches from an arbitrary patch tree, in case the tree
does not
  contain enough patches. Rather than conjuring meaningless patches out of
  thin air, a better solution is to reject starting states with not enough
  patches. Along the way, some unused functions and instances in the test
  harness were deleted.

patch c5799774a381f9637298c89729f5afdd21136448
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon May 28 16:50:29 CEST 2018
  * simplified withUMaskFlag

patch 87e91d2490d1231d97a8ebd046050596a45849d3
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Mar 26 01:42:11 CEST 2018
  * remove "withSignalsHandled:" from message when we are interrupted
(Ctrl-C)
  
  Prepending the function name makes sense for debug messages but not for
  messages intended for users (except bugs).

patch d542479a32f2c87a89c4d4326efe23ce6fb0e7ac
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Jun  8 14:04:57 CEST 2018
  * use +<<+ in D.P.Set.appendPSFL

patch 44a511c23ac528f34463905c9d97771785cfe2df
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Jun  9 13:29:43 CEST 2018
  * export getPrefLines for darcsden

patch 6f36789d84120ed295f414ac6ca79028fc4934fd
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Jun 10 11:28:26 CEST 2018
  * save one reverseFL in D.P.Depends.patchSetUnion

patch 5c62470eccb01a62e8524fad20014a6637e26521
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Jun 12 19:42:21 CEST 2018
  * add/change some comments in optimize upgrade command

patch aa411ed17681d3c9758e7d7b06d70ff0481ab5fa
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Jun 13 12:32:42 CEST 2018
  * renamed a local variable in tentativelyMergePatches
  
  The content of a named patch does not consist of prim patches.

patch 1e696cdfb8804fb5e9ae01d4aaebe978bb4971c0
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Jul  1 10:41:26 CEST 2018
  * fix: show pristine is not an alias of show index

patch 3916010aa0cbbfb870fbd8867ff454746ea1d5da
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Jul  2 00:46:39 CEST 2018
  * fix haddocks for maybeApplyToTree

patch 401e31d6ee6f70f8e0780066bac76ccbe7f2bc65
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Jul 13 19:07:51 CEST 2018
  * respect verbosity options in amend command
Attachments
msg20198 (view) Author: bf Date: 2018-07-17.16:11:07
Screening them all as either trivial or test related.
msg20219 (view) Author: ganesh Date: 2018-07-22.18:34:24
>  * remove method anIdentity from PrimConstruct

This is a good idea, it was always a bit of a hack.

> hunk ./src/Darcs/Patch/Prim/FileUUID/Core.hs 125
> -  anIdentity = Identity

I wonder if we can also remove this constructor now.

> +instance HasDefault Bool where
> +  def = False
> +

This feels a bit dangerous to me in general, but it's a local class 
and only in the tests anyway.

>  * simplified withUMaskFlag

Fine

>  * remove "withSignalsHandled:" from message when we are 
interrupted

Makes sense

>  * use +<<+ in D.P.Set.appendPSFL

Fine (it's worth remembering that the witnesses mean that reverseFL 
and reverseRL can't really have any semantic effect on a list, they 
just change the format.)

>  * export getPrefLines for darcsden

Fine

>  * save one reverseFL in D.P.Depends.patchSetUnion

Fine

>  * add/change some comments in optimize upgrade command

Fine

>  * renamed a local variable in tentativelyMergePatches

Fine

>  * fix: show pristine is not an alias of show index

Fine

>  * fix haddocks for maybeApplyToTree

Fine

>  * respect verbosity options in amend command

Fine
History
Date User Action Args
2018-07-17 16:03:16bfcreate
2018-07-17 16:11:07bfsetstatus: needs-screening -> needs-review
messages: + msg20198
2018-07-22 18:34:25ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg20219
2018-07-24 01:09:00ganeshsetstatus: accepted-pending-tests -> accepted