darcs

Patch 1704 avoid using PrimConstruct and PrimClassify in Pending

Title avoid using PrimConstruct and PrimClassify in Pending
Superseder Nosy List bf
Related Issues
Status review-in-progress Assigned To
Milestone

Created on 2018-07-18.09:22:41 by bf, last changed 2018-07-29.20:58:44 by ganesh.

Files
File name Status Uploaded Type Edit Remove
remove-commuteflorcomplain-and-replace-with-commutefl.dpatch bf, 2018-07-18.09:22:40 application/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg20199 (view) Author: bf Date: 2018-07-18.09:22:40
3 patches for repository http://darcs.net/screened:

patch 9b3de1c406a8fd768d34b663f6577fd9b2e613d3
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed May 16 09:40:50 CEST 2018
  * remove commuteFLorComplain and replace with commuteFL
  
  The extra information provided by commuteFLorComplain was nowhere used.

patch 20354fcfc3d9695b6a6652e1ae9f810cdb8fb824
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Mar  1 23:56:01 CET 2018
  * move tryShrinkingInverse to D.P.Invert, rename to dropInverses
  
  The function is defined solely in terms of Invert and Eq2.

patch 3da30f7bd97167b3c876255aa01999157e36253c
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat May  5 08:58:06 CEST 2018
  * add class PrimSift so we can avoid using PrimConstruct and
PrimClassify in Pending
Attachments
msg20200 (view) Author: bf Date: 2018-07-18.11:10:25
I talked about this on the mailing list. It is a first step on the way
toward making Darcs work with primitive patch types other than Prim.V1.

I am screening it because my later refactorings and bug fixes regarding
pending depend on this refactor; in fact would not have been possible
without the simplification it makes to D.R.Pending.
msg20231 (view) Author: ganesh Date: 2018-07-29.20:58:43
>   * remove commuteFLorComplain and replace with commuteFL

Fine

>  * move tryShrinkingInverse to D.P.Invert, rename to dropInverses

Fine. 'dropInitialInverses' might be a better name for this.

>  * add class PrimSift so we can avoid using PrimConstruct and
PrimClassify in Pending

I assume this is just a reorganisation of the code, no functionality 
changes? I haven't checked that line by line.

Why aren't the 'defaultV1' functions just placed directly in the V1 
implementation?
History
Date User Action Args
2018-07-18 09:22:41bfcreate
2018-07-18 11:10:25bfsetstatus: needs-screening -> needs-review
messages: + msg20200
2018-07-29 20:58:44ganeshsetstatus: needs-review -> review-in-progress
messages: + msg20231