darcs

Patch 1706 simplify D.R.Hashed.reorderInventory

Title simplify D.R.Hashed.reorderInventory
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone

Created on 2018-07-18.16:57:05 by bf, last changed 2018-08-24.14:31:24 by bf.

Files
File name Status Uploaded Type Edit Remove
simplify-d_r_hashed_reorderinventory.dpatch bf, 2018-07-18.16:57:05 text/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg20202 (view) Author: bf Date: 2018-07-18.16:57:05
1 patch for repository http://darcs.net/screened:

patch 287acd410dbf93a84b9ef58bf6ba18bf9617df92
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Jun  8 11:33:43 CEST 2018
  * simplify D.R.Hashed.reorderInventory
  
  This gets rid of the last use of tentativelyReplacePatches which has been
  removed. Instead of removing patches from the repo and then adding them
  back, we directly write the new patchset. tentativelyReplacePatches
filtered
  out the rebase patch from the patches it removes. This was brittle and
also
  unnecessary: we can assume the rebase patch is not covered by any tag and
  thus automatically belongs to the untagged tail of patches.
  
  Finding the latest tag and cleaning it is now optimized by using the new
  utility function breakRL. This avoids searching for the latest tag twice
  (first in misplacedPatches and then again in splitOnTag). The fused
  functionality is now in function D.P.Depends.cleanLatestTag.
  
  The test for darcs optimize has been enhanced to actually test that
optimize
  reorder does what it should.
Attachments
msg20222 (view) Author: ganesh Date: 2018-07-22.23:28:55
Nice cleanup - the new code is very easy to read.

Did you intend to remove the debug messages? I don't think they were 
very important but I don't think they hurt either and you never know 
when they might be useful.
msg20246 (view) Author: bf Date: 2018-08-24.14:31:23
With the much shorter and simpler definition I guess debug messages just
felt a bit heavy-weight now. Feel free to re-add them, however.
History
Date User Action Args
2018-07-18 16:57:05bfcreate
2018-07-22 23:28:55ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg20222
2018-07-24 01:09:11ganeshsetstatus: accepted-pending-tests -> accepted
2018-08-24 14:31:24bfsetmessages: + msg20246