darcs

Patch 1708 remove writePatchSet and patchSetToRepository from D.R.Clone

Title remove writePatchSet and patchSetToRepository from D.R.Clone
Superseder Nosy List bf, ganesh
Related Issues
Status accepted Assigned To ganesh
Milestone

Created on 2018-07-18.17:17:02 by bf, last changed 2018-08-13.06:30:08 by ganesh.

Files
File name Status Uploaded Type Edit Remove
remove-writepatchset-and-patchsettorepository-from-d_r_clone.dpatch bf, 2018-07-18.17:17:02 text/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg20204 (view) Author: bf Date: 2018-07-18.17:17:02
1 patch for repository http://darcs.net/screened:

patch 7e3363a7e73f36992651f1ccc1cdb4b36ccfb3f0
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Jun 10 17:10:03 CEST 2018
  * remove writePatchSet and patchSetToRepository from D.R.Clone
  
  patchSetToRepository was already commented out and writePatchSet was used
  only in D.UI.Commands.Repair, where the relevant parts are now
inlined. Also
  did some refactorings there while we're at it.
Attachments
msg20234 (view) Author: ganesh Date: 2018-07-31.06:09:59
Looks ok overall

This patch would have been a bit easier to review if it had been
multiple patches with the refactorings documented separately, e.g.
"replace putStrLn with putInfo", "simplify messages when checking 
pristine", and then finally the writePatchSet removal.

I sometimes use "rebase suspend" to temporarily put aside work in 
progress when I come across other cleanups at the same time.
History
Date User Action Args
2018-07-18 17:17:02bfcreate
2018-07-31 06:10:00ganeshsetstatus: needs-review -> accepted-pending-tests
assignedto: ganesh
messages: + msg20234
nosy: + ganesh
2018-08-13 06:30:08ganeshsetstatus: accepted-pending-tests -> accepted