As discussed on the list some time ago, the definitions at the head of
Darcs.Patch.Depends were inconsistent with the code. The second patch fixes
that and adds and improves documentation in various places. The first patch
cleans up the implementation of slightlyOptimizePatchset without changing
behavior.

2 patches for repository http://darcs.net/screened:

patch 67060a6eb9890833200a4f3d29de14780cdf0d63
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Jul 18 18:31:43 CEST 2018
  * simplify Darcs.Patch.Depends.slightlyOptimizePatchset

patch 53d146436be7078587bd687c61df2b2214bfd6af
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Aug 31 13:52:40 CEST 2018
  * fix and extend docs in D.P.Depends
  
  Most importantly, the definition of terms now corresponds to what the code
  does. This patch also adds a number of comments to the implementation of
  some tricky functions, like taggedIntersection.

Attachments

• patch-preview.txt
• simplify-darcs_patch_depends_slightlyoptimizepatchset.dpatch
• unnamed

> patch 67060a6eb9890833200a4f3d29de14780cdf0d63
> Author: Ben Franksen <ben.franksen@online.de>
> Date:   Wed Jul 18 18:31:43 CEST 2018
>  * simplify Darcs.Patch.Depends.slightlyOptimizePatchset

Fine - you do drop a nested call to progressRL, whose semantics I 
don't completely understand, but I don't think it's a big deal 
either way.

> you do drop a nested call to progressRL

That was deliberate: I expect this to be a pretty fast operation (no 
commutation, only the head inventory is traversed).

> patch 53d146436be7078587bd687c61df2b2214bfd6af
> Author: Ben Franksen <ben.franksen@online.de>
> Date:   Fri Aug 31 13:52:40 CEST 2018
>   * fix and extend docs in D.P.Depends

Fine.