darcs

Patch 1722 simplify Darcs.Patch.Depends.slightlyOpt... (and 1 more)

Title simplify Darcs.Patch.Depends.slightlyOpt... (and 1 more)
Superseder Nosy List bf, ganesh
Related Issues
Status accepted Assigned To ganesh
Milestone

Created on 2018-09-01.08:36:59 by bf, last changed 2018-10-03.19:27:17 by ganesh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bf, 2018-09-01.08:36:58 text/x-darcs-patch
simplify-darcs_patch_depends_slightlyoptimizepatchset.dpatch bf, 2018-09-01.08:36:58 application/x-darcs-patch
unnamed bf, 2018-09-01.08:36:58 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg20296 (view) Author: bf Date: 2018-09-01.08:36:58
As discussed on the list some time ago, the definitions at the head of
Darcs.Patch.Depends were inconsistent with the code. The second patch fixes
that and adds and improves documentation in various places. The first patch
cleans up the implementation of slightlyOptimizePatchset without changing
behavior.

2 patches for repository http://darcs.net/screened:

patch 67060a6eb9890833200a4f3d29de14780cdf0d63
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Jul 18 18:31:43 CEST 2018
  * simplify Darcs.Patch.Depends.slightlyOptimizePatchset

patch 53d146436be7078587bd687c61df2b2214bfd6af
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Aug 31 13:52:40 CEST 2018
  * fix and extend docs in D.P.Depends
  
  Most importantly, the definition of terms now corresponds to what the code
  does. This patch also adds a number of comments to the implementation of
  some tricky functions, like taggedIntersection.
Attachments
msg20302 (view) Author: ganesh Date: 2018-09-14.07:08:44
> patch 67060a6eb9890833200a4f3d29de14780cdf0d63
> Author: Ben Franksen <ben.franksen@online.de>
> Date:   Wed Jul 18 18:31:43 CEST 2018
>  * simplify Darcs.Patch.Depends.slightlyOptimizePatchset

Fine - you do drop a nested call to progressRL, whose semantics I 
don't completely understand, but I don't think it's a big deal 
either way.
msg20306 (view) Author: bf Date: 2018-09-14.09:38:08
> you do drop a nested call to progressRL

That was deliberate: I expect this to be a pretty fast operation (no 
commutation, only the head inventory is traversed).
msg20307 (view) Author: ganesh Date: 2018-09-14.19:57:37
> patch 53d146436be7078587bd687c61df2b2214bfd6af
> Author: Ben Franksen <ben.franksen@online.de>
> Date:   Fri Aug 31 13:52:40 CEST 2018
>   * fix and extend docs in D.P.Depends

Fine.
History
Date User Action Args
2018-09-01 08:36:59bfcreate
2018-09-01 08:37:56bfsetstatus: needs-screening -> needs-review
2018-09-14 07:08:47ganeshsetstatus: needs-review -> review-in-progress
assignedto: ganesh
messages: + msg20302
nosy: + ganesh
2018-09-14 09:38:08bfsetmessages: + msg20306
2018-09-14 19:57:38ganeshsetstatus: review-in-progress -> accepted-pending-tests
messages: + msg20307
2018-10-03 19:27:17ganeshsetstatus: accepted-pending-tests -> accepted