darcs

Patch 1723 replace most calls to getDirectoryConten... (and 1 more)

Title replace most calls to getDirectoryConten... (and 1 more)
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone

Created on 2018-09-01.09:41:09 by bf, last changed 2018-10-05.21:19:01 by ganesh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bf, 2018-09-01.09:41:09 text/x-darcs-patch
replace-most-calls-to-getdirectorycontent-with-listdirectory.dpatch bf, 2018-09-01.09:41:09 application/x-darcs-patch
unnamed bf, 2018-09-01.09:41:09 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg20297 (view) Author: bf Date: 2018-09-01.09:41:09
2 patches for repository http://darcs.net/screened:

patch e7a0937c113161485d6838442d4cb35505fc920c
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Jul 15 14:43:09 CEST 2018
  * replace most calls to getDirectoryContent with listDirectory
  
  This function has been around since directory-1.2.5.0 (we currently require
  at least 1.2.7). Using it lets us avoid manually filtering out "." and ".."
  entries.

patch 903db323f49a644c0872a8a83c0424cb28dd66e4
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Sep  1 11:36:55 CEST 2018
  * replace our rmRecursive with removeDirectoryRecursive from directory package
  
  This function has been fixed not to follow symbolic links since
  directory-1.2.2.0, so we no longer need to roll our own.
Attachments
msg20369 (view) Author: ganesh Date: 2018-10-05.18:42:31
>  * replace our rmRecursive with removeDirectoryRecursive from 
>    directory package

Fine

>  * replace most calls to getDirectoryContent with listDirectory

There's a small behaviour change in Darcs.Repository.Identify where
previously it would have ignored directories like ".foo", but I view
that as a bug fix.

There were some other cases with a similar code difference, but
searching for call sites showed they were only being called on
inventory or patches directories which wouldn't have dotfiles 
anyway.
History
Date User Action Args
2018-09-01 09:41:09bfcreate
2018-09-14 07:31:48ganeshsetstatus: needs-screening -> needs-review
2018-10-05 18:42:32ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg20369
2018-10-05 21:19:01ganeshsetstatus: accepted-pending-tests -> accepted