darcs

Patch 1724 resolve issue2599: don't bother to update pending when...

Title resolve issue2599: don't bother to update pending when...
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone

Created on 2018-09-01.10:13:39 by bf, last changed 2018-10-17.06:47:09 by ganesh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bf, 2018-09-01.10:13:39 text/x-darcs-patch
resolve-issue2599_-don_t-bother-to-update-pending-when-cloning-a-repo.dpatch bf, 2018-09-01.10:13:39 application/x-darcs-patch
unnamed bf, 2018-09-01.10:13:39 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg20298 (view) Author: bf Date: 2018-09-01.10:13:39
1 patch for repository http://darcs.net/screened:

patch a04c54380af24bbd912cf41b481cccd4f01071c5
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Jul 22 17:46:49 CEST 2018
  * resolve issue2599: don't bother to update pending when cloning a repo
Attachments
msg20381 (view) Author: ganesh Date: 2018-10-06.17:00:32
Seems reasonable, I can't think of a good reason to update pending
either. Maybe if you are cloning a repo with unresolved conflicts it
could leave effects in the working directory which sometimes need
to be in pending? Anyway, I'm not personally too worried if that
scenario gets a bit worse.
msg20387 (view) Author: bf Date: 2018-10-06.21:33:00
Hmm. I hadn't thought what happens when you clone unresolved 
conflicts. I think we should do the equivalent of mark-conflicts in 
that case, but I just checked and it looks as if we don't. This is 
unacceptable. An invitation to desaster! I can't believe we have no 
test for this. I'll open a new issue.

(To come back to the issue at hand: pending should be updated when we 
fix that, of course, but ATM should be unaffected.)
History
Date User Action Args
2018-09-01 10:13:39bfcreate
2018-09-14 07:31:53ganeshsetstatus: needs-screening -> needs-review
2018-10-06 17:00:33ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg20381
2018-10-06 21:33:00bfsetmessages: + msg20387
2018-10-17 06:47:09ganeshsetstatus: accepted-pending-tests -> accepted