darcs

Patch 1739 fix cache tests

Title fix cache tests
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone

Created on 2018-10-03.18:26:44 by bf, last changed 2018-11-16.16:14:42 by ganesh.

Files
File name Status Uploaded Type Edit Remove
fix-in-tests_lib-for-parallel-testing.dpatch bf, 2018-10-03.18:34:08 application/x-darcs-patch
fix-location-of-global-cache-dir-in-tests.dpatch bf, 2018-10-03.18:26:44 application/x-darcs-patch
fix-typo-in-test-comment.dpatch ganesh, 2018-11-16.08:50:36 application/x-darcs-patch
patch-preview.txt bf, 2018-10-03.18:26:44 text/x-darcs-patch
patch-preview.txt bf, 2018-10-03.18:34:08 text/x-darcs-patch
patch-preview.txt ganesh, 2018-11-16.08:50:36 text/x-darcs-patch
unnamed bf, 2018-10-03.18:26:44 text/plain
unnamed bf, 2018-10-03.18:34:08 text/plain
unnamed ganesh, 2018-11-16.08:50:36 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg20358 (view) Author: bf Date: 2018-10-03.18:26:44
The test for issue1702 fails now, so we have a regression. Indeed, a manual
check confirms that optimize relink doesn't work.

2 patches for repository http://darcs.net/screened:

patch a73d12e7b5a439f367d52a6c47a42e06727681bf
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Oct  3 16:49:28 CEST 2018
  * fix location of global cache dir in tests

patch fee8afc5d42df581954a00ea20f544b2032263a0
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Oct  3 20:21:15 CEST 2018
  * fix test for issue1702
  
  This test was completely broken and therefore always skipped.
Attachments
msg20360 (view) Author: bf Date: 2018-10-03.18:34:08
While we're at it, here are two more test fixes, one also related to cache
tests.

2 patches for repository http://darcs.net/screened:

patch 818122541edbaf4993bf4bff3cf4a0e267393aab
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Oct  3 16:36:51 CEST 2018
  * fix in tests/lib for parallel testing

patch dee826859f8a95862e485de9f287f92348b1ccde
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Oct  3 16:51:26 CEST 2018
  * throw away test repo dirs before running test
Attachments
msg20391 (view) Author: ganesh Date: 2018-10-10.06:12:29
* fix location of global cache dir in tests
>  * fix location of global cache dir in tests

> hunk ./tests/issue1702-optimize-relink-vs-cache.sh 3
> -## in ~/.darcs/cache.
> +## in ~/.config/darcs.
> hunk ./tests/issue1702-optimize-relink-vs-cache.sh 41
> -if [[ ! R/_darcs/patches/$x -ef ~/.darcs/cache/patches/$x ]]
> +if [[ ! R/_darcs/patches/$x -ef ~/.config/darcs/patches/$x ]]

Shouldn't this be .cache, not .config?
(Also the directory is wrong on Windows, but this doesn't make
things any worse, and anyway hardlinks probably don't exist)
msg20394 (view) Author: bf Date: 2018-10-11.09:57:01
Am 10.10.2018 um 08:12 schrieb Ganesh Sittampalam:
> (Also the directory is wrong on Windows, but this doesn't make
> things any worse, and anyway hardlinks probably don't exist)

Please open an issue for that. I want to bring Windows on par but I need
your help for that. XDG_CACHE_HOME is the variable on Linux, I guess
Windows has its own version.

Cheers
Ben
msg20466 (view) Author: ganesh Date: 2018-11-16.08:50:36
reattaching untracked patch
1 patch for repository /home/ganesh/darcs/screened-temp:

patch 5f03ad6b4df0d43f3dcf23340ae1bc60e4b2f2bf
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Oct 11 10:52:56 BST 2018
  * fix typo in test comment
Attachments
History
Date User Action Args
2018-10-03 18:26:44bfcreate
2018-10-03 18:30:20bfsettitle: fix location of global cache dir in tests (and 1 more) -> fix cache tests
2018-10-03 18:34:08bfsetfiles: + patch-preview.txt, fix-in-tests_lib-for-parallel-testing.dpatch, unnamed
messages: + msg20360
2018-10-03 18:35:12bfsetstatus: needs-screening -> needs-review
2018-10-10 06:12:29ganeshsetstatus: needs-review -> review-in-progress
messages: + msg20391
2018-10-11 09:57:02bfsetmessages: + msg20394
2018-11-16 08:50:37ganeshsetfiles: + patch-preview.txt, fix-typo-in-test-comment.dpatch, unnamed
messages: + msg20466
2018-11-16 09:01:30ganeshsetstatus: review-in-progress -> accepted-pending-tests
2018-11-16 16:14:42ganeshsetstatus: accepted-pending-tests -> accepted