darcs

Patch 1744 move mangleUnravelled to new class PrimMangleUnravelled

Title move mangleUnravelled to new class PrimMangleUnravelled
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To
Milestone

Created on 2018-10-14.00:02:08 by bfrk, last changed 2018-11-19.01:23:31 by bfrk.

Files
File name Status Uploaded Type Edit Remove
move-mangleunravelled-to-new-class-primmangleunravelled.dpatch bfrk, 2018-10-14.00:02:07 application/x-darcs-patch
patch-preview.txt bfrk, 2018-10-14.00:02:07 text/x-darcs-patch
unnamed bfrk, 2018-10-14.00:02:07 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg20402 (view) Author: bfrk Date: 2018-10-14.00:02:07
1 patch for repository http://darcs.net/screened:

patch 8ff084141427ba407b1961d8c5ab27d9aafc8f17
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Oct  3 20:49:13 CEST 2018
  * move mangleUnravelled to new class PrimMangleUnravelled
  
  This refactor serves two purposes: First, we isolate yet another bunch of
  code that heavily depends on Prim.V1, similar to the recent introduction of
  PrimSift. Second, while this is support code for generating the conflict
  resolution markup, it is not related to conflictors or conflicts per se; in
  fact, it works on and uses only features of prim patches.
Attachments
msg20482 (view) Author: ganesh Date: 2018-11-17.11:40:58
>  * move mangleUnravelled to new class PrimMangleUnravelled

Fine - this is a good direction to be moving. The patch also 
contains a refactoring of the PrimSift instance which also helps
to clarify the scope of certain bits of code.

I assume the patch is just moving code around and hasn't changed
any behaviour.
msg20527 (view) Author: bfrk Date: 2018-11-19.01:23:31
>>  * move mangleUnravelled to new class PrimMangleUnravelled
> 
> I assume the patch is just moving code around and hasn't changed
> any behaviour.

Yes.
History
Date User Action Args
2018-10-14 00:02:08bfrkcreate
2018-10-14 00:03:00bfrksetstatus: needs-screening -> needs-review
2018-11-17 11:40:59ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg20482
2018-11-17 15:45:53ganeshsetstatus: accepted-pending-tests -> accepted
2018-11-19 01:23:31bfrksetmessages: + msg20527