darcs

Patch 1751 avoid importing Data.ByteString.Internals (and 8 more)

Title avoid importing Data.ByteString.Internals (and 8 more)
Superseder Nosy List bfrk, ganesh
Related Issues
Status accepted Assigned To ganesh
Milestone

Created on 2018-10-18.21:52:35 by bfrk, last changed 2018-11-17.23:25:12 by ganesh.

Files
File name Status Uploaded Type Edit Remove
avoid-importing-data_bytestring_internals.dpatch bfrk, 2018-10-18.21:52:34 application/x-darcs-patch
patch-preview.txt bfrk, 2018-10-18.21:52:34 text/x-darcs-patch
unnamed bfrk, 2018-10-18.21:52:34 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg20422 (view) Author: bfrk Date: 2018-10-18.21:52:34
Assorted minor cleanups that I have been gathering over the last few weeks.

9 patches for repository http://darcs.net/screened:

patch 0b84339916e9c98662e71030f6339ad30ce798bf
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Sep 23 19:25:17 CEST 2018
  * avoid importing Data.ByteString.Internals
  
  Even though here it was only for the c2w function, we should reduce access
  to BS internals to the absolute minimum necessary.

patch 5533d970840b66ed0a9041b03ffd302a381d448f
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Sep 23 19:47:23 CEST 2018
  * fixed typo in doc comment

patch c035ef388503ede2e75561c612bf71c6bb809297
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Sep 23 19:47:52 CEST 2018
  * D.P.Match: layout changes to avoid overlong lines

patch 11667fd6ea4c513d1c75839e81d06db7bd6beb45
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Sep 30 19:26:56 CEST 2018
  * import MVar from Control.Concurrent.MVar, not GHC.MVar

patch d5358d80f8f9ba8059540227d8613779cc1d7ba5
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Sep 30 23:06:35 CEST 2018
  * rename repodir to repourl in D.R.Clone

patch 23aa198df96db5587b37b760d31651190fd5faa8
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Oct  8 19:23:06 CEST 2018
  * use anchoredRoot instead of AnchoredPath [] in index code

patch 0e875b487f9bcf18e0f032cacb40948ed4645620
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Oct 12 23:27:55 CEST 2018
  * remove TypeOperators language pragmas
  
  This extension is already globally activated in the cabal file.

patch 159052d2c96345dad8c6e20de7e52648dfad9994
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Oct 12 23:36:58 CEST 2018
  * print remote execution failure message to stderr

patch 7815e0d87902049273d747a62bd5c54ab9794dc7
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Oct 13 01:17:28 CEST 2018
  * output patch apply success message with putInfo
Attachments
msg20490 (view) Author: ganesh Date: 2018-11-17.16:03:25
>   * avoid importing Data.ByteString.Internals

Fine, the BI usage here was pretty pointless/gratuitous


>  * fixed typo in doc comment

Fine

>  * D.P.Match: layout changes to avoid overlong lines

Fine


>   * import MVar from Control.Concurrent.MVar, not GHC.MVar

Fine

>   * rename repodir to repourl in D.R.Clone

Fine

>  * use anchoredRoot instead of AnchoredPath [] in index code

Fine

>   * remove TypeOperators language pragmas

Fine

>   * print remote execution failure message to stderr

Fine

>   * output patch apply success message with putInfo

Fine
History
Date User Action Args
2018-10-18 21:52:35bfrkcreate
2018-10-18 21:56:00bfrksetstatus: needs-screening -> needs-review
2018-11-17 16:03:25ganeshsetstatus: needs-review -> accepted-pending-tests
assignedto: ganesh
messages: + msg20490
nosy: + ganesh
2018-11-17 23:25:12ganeshsetstatus: accepted-pending-tests -> accepted