darcs

Patch 1753 move cache related global variables to D.R.Cache and m...

Title move cache related global variables to D.R.Cache and m...
Superseder Nosy List bfrk, ganesh
Related Issues
Status accepted Assigned To ganesh
Milestone

Created on 2018-10-18.22:01:11 by bfrk, last changed 2018-11-17.23:25:18 by ganesh.

Files
File name Status Uploaded Type Edit Remove
move-cache-related-global-variables-to-d_r_cache-and-make-them-thread_safe.dpatch bfrk, 2018-10-18.22:01:11 application/x-darcs-patch
patch-preview.txt bfrk, 2018-10-18.22:01:11 text/x-darcs-patch
unnamed bfrk, 2018-10-18.22:01:11 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg20424 (view) Author: bfrk Date: 2018-10-18.22:01:11
1 patch for repository http://darcs.net/screened:

patch 2bc54badcea883da5eb45ed794b8d3ef1f37a3e1
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Sep 29 18:35:53 CEST 2018
  * move cache related global variables to D.R.Cache and make them thread-safe
  
  The two global variables are reachableSourcesList and badSourcesList and
  they are exclusively used by D.R.Cache. So it seems cleaner to me to
  encapsulate them in the same module. They use MVars now to make access
  thread safe. While apparently the code seems to work with IORefs, the cache
  functions /are/ used from multiple threads, so MVars are the safer option.
Attachments
msg20493 (view) Author: ganesh Date: 2018-11-17.16:15:03
>   * move cache related global variables to D.R.Cache and make them 
thread-safe

Fine. I think atomicModifyIORef would also work here either is fine.
History
Date User Action Args
2018-10-18 22:01:11bfrkcreate
2018-10-18 22:03:47bfrksetstatus: needs-screening -> needs-review
2018-11-17 16:15:04ganeshsetstatus: needs-review -> accepted-pending-tests
assignedto: ganesh
messages: + msg20493
nosy: + ganesh
2018-11-17 23:25:18ganeshsetstatus: accepted-pending-tests -> accepted