darcs

Patch 1757 accept issue2605: darcs crashes with duplicate patches

Title accept issue2605: darcs crashes with duplicate patches
Superseder Nosy List bf, ganesh
Related Issues
Status accepted Assigned To ganesh
Milestone

Created on 2018-10-28.16:39:58 by bf, last changed 2018-11-23.21:26:33 by ganesh.

Files
File name Status Uploaded Type Edit Remove
accept-issue2605_-darcs-crashes-with-duplicate-patches.dpatch bf, 2018-10-28.16:39:57 application/x-darcs-patch
issue2605-test-is-currently-failing.dpatch ganesh, 2018-11-18.12:48:59 application/x-darcs-patch
patch-preview.txt bf, 2018-10-28.16:39:57 text/x-darcs-patch
patch-preview.txt ganesh, 2018-11-18.12:48:59 text/x-darcs-patch
unnamed bf, 2018-10-28.16:39:57 text/plain
unnamed ganesh, 2018-11-18.12:48:59 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg20430 (view) Author: bf Date: 2018-10-28.16:39:57
BTW, my opinion on this is that being able to replace an implicit dependency
is a very nice and useful feature. Fixing this bug should be easy.

1 patch for repository http://darcs.net/screened:

patch e58e96882a706d6a854029b393f1a58c47aa2bbf
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Oct 28 14:47:18 CET 2018
  * accept issue2605: darcs crashes with duplicate patches
Attachments
msg20501 (view) Author: ganesh Date: 2018-11-18.10:00:25
This test isn't marked as failing which means screened is broken, is
that intentional?
msg20502 (view) Author: bf Date: 2018-11-18.12:15:33
No that wasn't intentional, sorry. I can send a rename patch and 
push it and then rebase the bundle that fixes the issue. Or I can 
push the fix, which I haven't done yet. I would prefer the latter.

The reason I didn't push it yet is to give you a chance to comment 
on the general direction this goes. The fix changes the semantics of 
merging from by-name to by-value/content. I thought this may provoke 
dissent even though the underlying commute machinery has always been 
by-value and I am pretty sure it is impossible to fix this bug in 
any other way except by adding prim patch identifiers (as proposed 
long ago by Ian Lynagh).
msg20504 (view) Author: ganesh Date: 2018-11-18.12:46:41
Thanks, I've got a rename locally, I'll push that for now.

I'll comment on the fix once I've had time to collect my thoughts
properly (hopefully within the next couple of days).
msg20505 (view) Author: ganesh Date: 2018-11-18.12:48:59
1 patch for repository darcs-unstable@darcs.net:screened:

patch ecc7509b36b8ee98a535226c9e2f880cc549dc91
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sun Nov 18 11:10:30 GMT 2018
  * issue2605 test is currently failing
Attachments
History
Date User Action Args
2018-10-28 16:39:58bfcreate
2018-10-28 16:40:22bfsetstatus: needs-screening -> needs-review
2018-11-18 10:00:25ganeshsetstatus: needs-review -> review-in-progress
assignedto: ganesh
messages: + msg20501
nosy: + ganesh
2018-11-18 12:15:34bfsetmessages: + msg20502
2018-11-18 12:46:41ganeshsetstatus: review-in-progress -> accepted-pending-tests
messages: + msg20504
2018-11-18 12:49:00ganeshsetfiles: + patch-preview.txt, issue2605-test-is-currently-failing.dpatch, unnamed
messages: + msg20505
2018-11-23 21:26:33ganeshsetstatus: accepted-pending-tests -> accepted