darcs

Patch 1759 new implementation of http client based on http-conduit

Title new implementation of http client based on http-conduit
Superseder Nosy List bf, ganesh
Related Issues
Status accepted Assigned To ganesh
Milestone

Created on 2018-11-08.18:35:34 by bf, last changed 2018-11-18.15:07:52 by ganesh.

Files
File name Status Uploaded Type Edit Remove
new-implementation-of-http-client-based-on-http_conduit.dpatch bf, 2018-11-08.18:35:33 application/x-darcs-patch
patch-preview.txt bf, 2018-11-08.18:35:33 text/x-darcs-patch
unnamed bf, 2018-11-08.18:35:33 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg20445 (view) Author: bf Date: 2018-11-08.18:35:33
1 patch for repository http://darcs.net/screened:

patch 4f0f6e70180b32c11fe125431ec4de96ced3e764
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Sep 25 19:03:11 CEST 2018
  * new implementation of http client based on http-conduit
  
  This implementation does not use our self-written download manager in
  Darcs.Util.Download, which is needed only to interact with libcurl. Instead,
  speculating on a remote file is done simply by running the action in a
  background thread (using async) and relying on the connection manager that
  is supplied with http-conduit. This works pretty well and gives us the full
  functionality (including HTTPS) in a portable manner, so I switched the
  default for the curl flag in darcs.cabal to False.
Attachments
msg20461 (view) Author: bf Date: 2018-11-15.14:58:21
Note that lately I am getting failures for these tests:

network/clone
network/lazy-clone

Its says:

Not a repository: http://hub.darcs.net/kowey/tabular (Problem with the
SSL CA cert (path? access rights?))

With this patch applied I can get http://hub.darcs.net/kowey/tabular
just fine.

Ganesh: could you check that this patch works on Windows? If it does I
would like to screen this patch.
msg20464 (view) Author: ganesh Date: 2018-11-15.19:42:09
Yes, it does work on Windows. Thank you! All the other Windows breaks 
are forgiven ;-) I've pushed it to screened.
msg20500 (view) Author: ganesh Date: 2018-11-18.09:38:25
Looks fine. Did you try out the POST functionality? I don't think
it's commonly used though we'd like to use it with darcsden.

I wonder if we can just drop the curl variant completely. Maybe
wait for a release or two to give people time to detect problems 
with the new implementation.
msg20503 (view) Author: bf Date: 2018-11-18.12:22:40
I did not try POST because I have no idea how to set up a test for 
this feature. We should have a regression test for this but I don't 
think we do.
msg20506 (view) Author: ganesh Date: 2018-11-18.12:49:47
I think in theory you can set up a receiver with contrib/upload.cgi
but I haven't tried to use that for many years. I think we can do
without testing POST for now.
History
Date User Action Args
2018-11-08 18:35:34bfcreate
2018-11-15 14:58:22bfsetmessages: + msg20461
2018-11-15 19:42:09ganeshsetstatus: needs-screening -> needs-review
messages: + msg20464
2018-11-18 09:38:26ganeshsetstatus: needs-review -> accepted-pending-tests
assignedto: ganesh
messages: + msg20500
nosy: + ganesh
2018-11-18 12:22:40bfsetmessages: + msg20503
2018-11-18 12:49:47ganeshsetmessages: + msg20506
2018-11-18 15:07:52ganeshsetstatus: accepted-pending-tests -> accepted