darcs

Patch 1775 Assorted collection of minor code cleanups (18 patches)

Title Assorted collection of minor code cleanups (18 patches)
Superseder Nosy List bf
Related Issues
Status needs-review Assigned To
Milestone

Created on 2018-12-04.17:24:51 by bf, last changed 2018-12-04.17:42:39 by bf.

Files
File name Status Uploaded Type Edit Remove
darcs_util_tree_hashed_-add-debug-messages-and-factor-out-showhash.dpatch bf, 2018-12-04.17:24:50 application/x-darcs-patch
patch-preview.txt bf, 2018-12-04.17:24:50 text/x-darcs-patch
unnamed bf, 2018-12-04.17:24:50 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg20573 (view) Author: bf Date: 2018-12-04.17:24:50
Assorted collection of minor code cleanups accumulated over the past few
weeks. None of them make any substantial change to the code base; for some
of the layout changes you'll have to trust me on that. The rest is mostly
removing unreferenced code, some of which was in the way of more substantial
changes I'll send separately.

18 patches for repository http://darcs.net/screened:

patch cc5961887b87f80a9518ccfd2014a52f46753224
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Dec  4 14:14:37 CET 2018
  * Darcs.Util.Tree.Hashed: add debug messages and factor out showHash

patch 8e33672608c1ea62423dbe26c8ee394f42661369
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Oct 18 10:54:02 CEST 2018
  * remove unused method effectRL from class Effect

patch 135f1149ed48f28f967a77b8b26aa421f65e7663
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Oct 18 12:26:51 CEST 2018
  * removed unneeded pseudo-instances for class Effect

patch 13009bb43b0324b3bfee61f57dd8d981550db7c5
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Nov 12 10:07:05 CET 2018
  * remove unused option optimizePatchIndex
  
  This option became a subcommand some time ago.

patch 5249e5fb34ee4a8330ce68034d09f172208246d5
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Nov 12 10:12:18 CET 2018
  * group --reorder under the merge options and improve its help text

patch 5aae2881494d7fd808998095eece7457ae745644
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Nov 13 11:19:57 CET 2018
  * move removeFromTentativeInventory closer to its single call site

patch d60c4da4309311bc5e96e2fcc7fcd2d7e0b114b7
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Nov 13 17:54:14 CET 2018
  * Darcs.Repository.Clone: turn two comments into debug messages

patch 8a8a98865c1935723a2d6a207b0f3334c8d94560
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Nov 13 17:54:20 CET 2018
  * Darcs.Repository.Clone: fix a comment

patch b80d42182484ff4e5da87f9b5d4d807f80587a66
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Nov 14 22:05:02 CET 2018
  * D.R.Merge: use displayPath for path display

patch a0b70ded00a2b18d23caf4b8340a0697e17f1ad6
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Jul 27 10:35:06 CEST 2018
  * remove outdated haddocks for revertRepositoryChanges

patch ad6e238ea20eafdf0efde0edd38403b2de024d34
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Nov 11 20:47:30 CET 2018
  * remove unused functions choosePreTouching and selectTouching

patch 15a1c521c7c350520b236cbab000bf88e72bd88d
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Nov 15 18:08:21 CET 2018
  * Darcs.Repository.Clone: clean up imports from D.R.Hashed

patch a25111c7450d2ae353d522ea043e9e513ea5b797
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Nov 15 20:57:35 CET 2018
  * revert command: break overlong lines (layout only)

patch 94cd11f184fde69473a7190277ffd103775333dc
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Nov 15 22:18:47 CET 2018
  * remove duplicate definition of catchall in Darcs.UI.External
  
  Instead use the one from Darcs.Util.Exception.

patch 8195885a2f47c7bb10a1c67bb4ea972ef0d0cf3b
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Nov 16 09:42:17 CET 2018
  * layout in D.UI.C.Amend.addChangesToPatch

patch 576dd8b689d308c1761e5c9eda03d04fa6345fc9
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Nov 16 10:01:56 CET 2018
  * slightly simplify withManualRebaseUpdate

patch e587d3a8837626433b65209472f8140f90a79a42
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Dec  3 16:04:53 CET 2018
  * remove unused/obsolete src/win32/sys/mman.h

patch 3c4fbcecce288a97c866d55955913f24d743d776
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Nov 25 14:33:50 CET 2018
  * layout changes to avoid overlong lines in Darcs.Util.Tree.Monad
Attachments
History
Date User Action Args
2018-12-04 17:24:51bfcreate
2018-12-04 17:28:36bfsettitle: Darcs.Util.Tree.Hashed: add debug messag... (and 17 more) -> Assorted collection of minor code cleanups (18 patches)
2018-12-04 17:42:39bfsetstatus: needs-screening -> needs-review