Patch 1778: replace Darcs.Util.Workaround.renameFile with System.D... - Darcs bug tracker

Title	replace Darcs.Util.Workaround.renameFile with System.D...
Superseder		Nosy List	bfrk
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2018-12-04.18:09:27 by bfrk, last changed 2019-06-02.21:23:56 by ganesh.

Files
File name	Status	Uploaded	Type	Edit	Remove
patch-preview.txt		bfrk, 2018-12-04.18:09:27	text/x-darcs-patch
replace-darcs_util_workaround_renamefile-with-system_directory_renamefile.dpatch		bfrk, 2018-12-04.18:09:27	application/x-darcs-patch
unnamed		bfrk, 2018-12-04.18:09:27	text/plain

See mailing list archives for discussion on individual patches.

Messages
msg20577 (view)	Author: bfrk	Date: 2018-12-04.18:09:27
There are already a number of places in our code where we use the renameFile from System.Directory directly, and where the target file name is expected to exist. The bug mentioned in the docs for the work-around must have been in some ancient version of the directory package that we no longer support. 1 patch for repository http://darcs.net/screened: patch 979f3b69f76f5ce5e8dcfdac38545d6fa44f3fd8 Author: Ben Franksen <ben.franksen@online.de> Date: Tue Dec 4 14:14:36 CET 2018 * replace Darcs.Util.Workaround.renameFile with System.Directory.renameFile Attachments patch-preview.txt replace-darcs_util_workaround_renamefile-with-system_directory_renamefile.dpatch unnamed
msg20675 (view)	Author: ganesh	Date: 2019-06-02.19:09:53
Looks fine - I double-checked that System.Directory.renameFile seems to work fine on Windows too.

History
Date	User	Action	Args
2018-12-04 18:09:27	bfrk	create
2018-12-04 18:20:02	bfrk	set	status: needs-screening -> needs-review
2019-06-02 19:09:54	ganesh	set	status: needs-review -> accepted-pending-tests messages: + msg20675
2019-06-02 21:23:56	ganesh	set	status: accepted-pending-tests -> accepted