darcs

Patch 1780 minimize context inside unrevert patch at the head of ...

Title minimize context inside unrevert patch at the head of ...
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To
Milestone

Created on 2018-12-04.18:17:17 by bfrk, last changed 2019-06-14.12:30:39 by ganesh.

Files
File name Status Uploaded Type Edit Remove
minimize-context-inside-unrevert-patch-at-the-head-of-the-unrevert-bundle.dpatch bfrk, 2018-12-04.18:17:17 application/x-darcs-patch
patch-preview.txt bfrk, 2018-12-04.18:17:17 text/x-darcs-patch
unnamed bfrk, 2018-12-04.18:17:17 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg20579 (view) Author: bfrk Date: 2018-12-04.18:17:17
1 patch for repository http://darcs.net/screened:

patch ad2a2b48618ccfdf78e41c6f8bbd1b754b9a6832
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Nov 16 09:55:05 CET 2018
  * minimize context inside unrevert patch at the head of the unrevert bundle
  
  This does not minimize the context consisting of named patches in the bundle
  itself. Instead, only the prim patches that go inside the anonymous patch at
  the head of the unrevert bundle are affected.
Attachments
msg20689 (view) Author: ganesh Date: 2019-06-04.05:42:27
OK.

I had to think about this a bit to understand what's going on with
the unrevert patch. First the user splits unrecorded into 'norevert'
then 'p' (the stuff to be reverted). But the unrevert patch
needs to be relative to recorded, not unrecorded. So we need
to commute p with norevert, and if that fails then keep some
of norevert in the unrevert patch so it still makes sense. This
patch is about minimising how much of norevert we keep, rather than
the existing all/nothing decision.
msg20715 (view) Author: bfrk Date: 2019-06-11.15:15:52
> I had to think about this a bit to understand what's going on with
> the unrevert patch. First the user splits unrecorded into 'norevert'
> then 'p' (the stuff to be reverted). But the unrevert patch
> needs to be relative to recorded, not unrecorded. So we need
> to commute p with norevert, and if that fails then keep some
> of norevert in the unrevert patch so it still makes sense. This
> patch is about minimising how much of norevert we keep, rather than
> the existing all/nothing decision.

Exactly. It took me a while to figure that one out myself. Should put a
comment in the code, perhaps just copy and paste what you wrote above.
msg20795 (view) Author: ganesh Date: 2019-06-14.12:30:39
I added the comment in patch1822
History
Date User Action Args
2018-12-04 18:17:17bfrkcreate
2018-12-04 18:27:29bfrksetstatus: needs-screening -> needs-review
2019-06-04 05:42:27ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg20689
2019-06-04 07:34:52ganeshsetstatus: accepted-pending-tests -> accepted
2019-06-11 15:15:52bfrksetmessages: + msg20715
2019-06-14 12:30:39ganeshsetmessages: + msg20795