darcs

Patch 1782 remove option --restrict-paths

Title remove option --restrict-paths
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To
Milestone

Created on 2018-12-04.18:32:12 by bfrk, last changed 2019-06-14.12:09:39 by ganesh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bfrk, 2018-12-04.18:32:11 text/x-darcs-patch
remove-option-__restrict_paths.dpatch bfrk, 2018-12-04.18:32:11 application/x-darcs-patch
unnamed bfrk, 2018-12-04.18:32:11 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg20582 (view) Author: bfrk Date: 2018-12-04.18:32:11
1 patch for repository http://darcs.net/screened:

patch 254ba064e656a2322bce1913d93def767fbb2ba4
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Nov 12 10:30:35 CET 2018
  * remove option --restrict-paths
  
  I can't think of a situation where allowing patches to manipulate paths
  outside of the repository makes sense.
Attachments
msg20583 (view) Author: bfrk Date: 2018-12-04.18:37:46
Just to make it clear, what this patch removes is the option to pass
--no-restrict-paths which removes checking for mal-formed paths in
patches (--restrict-paths was the default and can no longer be turned off).
msg20676 (view) Author: ganesh Date: 2019-06-02.19:12:18
I have no idea why this option was added. If people have
symlinked from inside the repo to outside then I guess this would
still be ok as the paths darcs sees would be inside.

We can see if anyone complains, anyway :-)
History
Date User Action Args
2018-12-04 18:32:12bfrkcreate
2018-12-04 18:37:47bfrksetstatus: needs-screening -> needs-review
messages: + msg20583
2019-06-02 19:12:18ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg20676
2019-06-14 12:09:39ganeshsetstatus: accepted-pending-tests -> accepted