Patch 1785: make API of Darcs.Repository.Rebase a bit more type safe - Darcs bug tracker

Title	make API of Darcs.Repository.Rebase a bit more type safe
Superseder		Nosy List	bfrk
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2018-12-04.18:51:39 by bfrk, last changed 2019-06-02.18:01:47 by ganesh.

Files
File name	Status	Uploaded	Type	Edit	Remove
make-api-of-darcs_repository_rebase-a-bit-more-type-safe.dpatch		bfrk, 2018-12-04.18:51:39	application/x-darcs-patch
patch-preview.txt		bfrk, 2018-12-04.18:51:39	text/x-darcs-patch
unnamed		bfrk, 2018-12-04.18:51:39	text/plain

See mailing list archives for discussion on individual patches.

Messages
msg20586 (view)	Author: bfrk	Date: 2018-12-04.18:51:39
1 patch for repository http://darcs.net/screened: patch 0378b7fb2e8ddbd346966280a14a7a5fa9d6b47e Author: Ben Franksen <ben.franksen@online.de> Date: Thu Nov 15 22:53:04 CET 2018 * make API of Darcs.Repository.Rebase a bit more type safe Attachments make-api-of-darcs_repository_rebase-a-bit-more-type-safe.dpatch patch-preview.txt unnamed
msg20593 (view)	Author: ganesh	Date: 2018-12-06.07:01:46
Looks OK - I had to think about it a bit, so maybe r and r' could be better named and/or there could be some doc comments. I don't think this change adds much type safety, as the rebase modification operation is still unsafe in itself until tentative has been changed. But I guess that's the nature of low-level operations that only update a single part of the repository state - it's up to higher-level things like tentativelyAddPatch_ to correctly orchestrate them.

History
Date	User	Action	Args
2018-12-04 18:51:39	bfrk	create
2018-12-04 18:51:47	bfrk	set	status: needs-screening -> needs-review
2018-12-06 07:01:47	ganesh	set	status: needs-review -> accepted-pending-tests messages: + msg20593
2019-06-02 18:01:47	ganesh	set	status: accepted-pending-tests -> accepted