darcs

Patch 1786 fix in move command after AnchoredPath refactor

Title fix in move command after AnchoredPath refactor
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To
Milestone

Created on 2018-12-14.15:35:38 by bfrk, last changed 2019-06-11.15:21:06 by bfrk.

Files
File name Status Uploaded Type Edit Remove
fix-in-move-command-after-anchoredpath-refactor.dpatch bfrk, 2018-12-14.15:35:38 application/x-darcs-patch
patch-preview.txt bfrk, 2018-12-14.15:35:38 text/x-darcs-patch
unnamed bfrk, 2018-12-14.15:35:38 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg20605 (view) Author: bfrk Date: 2018-12-14.15:35:38
1 patch for repository http://darcs.net/screened:

patch e7deaaf36fec242dad1efe29ccc72e145da20965
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Dec 14 14:04:14 CET 2018
  * fix in move command after AnchoredPath refactor
  
  The command didn't take into account that pathsFromArgs filters out invalid
  paths. This could lead to crashes (pattern match failure).
Attachments
msg20692 (view) Author: ganesh Date: 2019-06-04.06:08:46
OK (is this worth a test?)
msg20716 (view) Author: bfrk Date: 2019-06-11.15:21:06
> OK (is this worth a test?)

Hm, yes, obviously this wasn't covered by our tests or else I should
have noticed it earlier.
History
Date User Action Args
2018-12-14 15:35:38bfrkcreate
2018-12-19 16:40:29bfrksetstatus: needs-screening -> needs-review
2019-06-04 06:08:46ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg20692
2019-06-04 07:34:58ganeshsetstatus: accepted-pending-tests -> accepted
2019-06-11 15:21:06bfrksetmessages: + msg20716