darcs

Patch 1790 resolve issue2617: convert import crashes with out-of-...

Title resolve issue2617: convert import crashes with out-of-...
Superseder Nosy List bf, ganesh
Related Issues convert import crashes with out-of-order tags
View: 2617
Status review-in-progress Assigned To ganesh
Milestone

Created on 2019-01-22.16:15:32 by bf, last changed 2019-01-24.11:07:05 by bf.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bf, 2019-01-22.16:15:32 text/x-darcs-patch
patch-preview.txt bf, 2019-01-24.11:06:36 text/x-darcs-patch
resolve-issue2617_-convert-import-crashes-with-out_of_order-tags.dpatch bf, 2019-01-22.16:15:32 application/x-darcs-patch
simplify-_ignoring-out_of_order-tag_-warning-for-darcs-convert-import.dpatch bf, 2019-01-24.11:06:36 application/x-darcs-patch
unnamed bf, 2019-01-22.16:15:32 text/plain
unnamed bf, 2019-01-24.11:06:36 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg20619 (view) Author: bf Date: 2019-01-22.16:15:32
1 patch for repository http://darcs.net/screened:

patch d835f545f6db42e915051b73879f9bacc9d20c01
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Jan 22 17:13:46 CET 2019
  * resolve issue2617: convert import crashes with out-of-order tags
Attachments
msg20629 (view) Author: ganesh Date: 2019-01-24.06:30:05
> -          head (lines $ decodeLocale msg)
> +          head (decodeLocale tag : lines (decodeLocale msg))

Isn't this new code really just `decodeLocal tag`?

Looks fine otherwise, I guess we might as well put this in 2.14.2.
msg20632 (view) Author: bf Date: 2019-01-24.11:06:36
1 patch for repository http://darcs.net/screened:

patch 0a86c07cb6f37d2b4ab6a340fee303339dc20912
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Jan 24 12:05:33 CET 2019
  * simplify "Ignoring out-of-order tag" warning for darcs convert import
Attachments
msg20633 (view) Author: bf Date: 2019-01-24.11:07:05
>> -          head (lines $ decodeLocale msg)
>> +          head (decodeLocale tag : lines (decodeLocale msg))

Gah. Right. Simplification sent separately.
History
Date User Action Args
2019-01-22 16:15:32bfcreate
2019-01-22 16:25:19bfsetstatus: needs-screening -> needs-review
2019-01-24 06:30:06ganeshsetstatus: needs-review -> review-in-progress
assignedto: ganesh
messages: + msg20629
issues: + convert import crashes with out-of-order tags
nosy: + ganesh
2019-01-24 11:06:36bfsetfiles: + patch-preview.txt, simplify-_ignoring-out_of_order-tag_-warning-for-darcs-convert-import.dpatch, unnamed
messages: + msg20632
2019-01-24 11:07:05bfsetmessages: + msg20633