darcs

Patch 1792 inline function Darcs.Patch.Named.namepatch (and 9 more)

Title inline function Darcs.Patch.Named.namepatch (and 9 more)
Superseder Nosy List bf
Related Issues
Status needs-review Assigned To
Milestone

Created on 2019-01-24.11:00:43 by bf, last changed 2019-01-24.15:46:36 by bf.

Files
File name Status Uploaded Type Edit Remove
add-class-ideq2-to-darcs_patch_ident.dpatch bf, 2019-01-24.15:46:35 application/x-darcs-patch
inline-function-darcs_patch_named_namepatch.dpatch bf, 2019-01-24.11:00:42 application/x-darcs-patch
patch-preview.txt bf, 2019-01-24.11:00:42 text/x-darcs-patch
patch-preview.txt bf, 2019-01-24.15:46:35 text/x-darcs-patch
unnamed bf, 2019-01-24.11:00:42 text/plain
unnamed bf, 2019-01-24.15:46:35 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg20631 (view) Author: bf Date: 2019-01-24.11:00:42
This bundle consists purely of refactors with no change in behavior. The
goal is to prepare screened for integration of RepoPatchV3 which needs to
add identities to the prim patches it contains.

10 patches for repository http://darcs.net/screened:

patch c9c9bd06432fd34b305a2bcba6d05d68c0e4b3ff
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Jan 22 14:21:11 CET 2019
  * inline function Darcs.Patch.Named.namepatch
  
  This is in preparation of adding identifiers to prims when constructing
  named patches.

patch b0785ecb52aef2e8740b7fc92c747dde0e52116c
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Jan 22 18:21:58 CET 2019
  * refactor: eliminate class FromPrims
  
  Again, preparation for adding identities to prim patches. The method
  fromPrims was used mainly to construct Named patches via infopatch or
  anonymous from Darcs.Patch.Named. These functions now take an FL of prim
  patches as input.

patch 36033bed448aa323bc06b92dc367b193a9b86f13
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Jan 22 18:31:08 CET 2019
  * eliminate an unneeded use of fromPrim

patch c7832c1bef06d3c495eacc201a2a3b2984e32d14
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Jan 22 18:57:20 CET 2019
  * eliminate use of fromPrim in convertDarcs2
  
  The code now uses the data constructor V2.Normal instead.

patch b08f89556cd0304dc3bf024dcee9e4d4870ca363
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Jan 22 19:30:12 CET 2019
  * remove instances for FromPrim and PrimPatchBase for prim types

patch 08423b471438c372f0580dcb1046f09f2dbff090
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Jan 22 19:40:24 CET 2019
  * move instance FromPrim (FL p) to Darcs.Test.Patch.Examples.Set1
  
  This is the only place where the instance is used.

patch fbcdcb8f5cb8c8dcff596d1c7a26c3a56bf0ec12
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Jan 22 20:24:39 CET 2019
  * move classes PrimPatchBase, FromPrim, and ToFromPrim to their own module
  
  These classes are not part of the Prim patch API but the RepoPatch API.

patch 15b4e8f05c2fbf44854339aa26f99181881c3e2b
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Jan 22 20:33:14 CET 2019
  * remove fromPrim from Darcs.Patch
  
  This is now no longer an official part of the Patch API.

patch 8a2472cf734f71e1ca48660d0865399eff2d5718
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Jan 22 20:42:21 CET 2019
  * avoid direct imports of Darcs.Patch.FromPrim from outside of Darcs.Patch
  
  The only exception is now the implementation of rebase inject which needs
  low-level access to fromPrim.

patch d7a58ef262d38d0a3a4adbdf234e2421ddc1adde
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Jan 23 15:58:55 CET 2019
  * remove class PrimPatchCommon
Attachments
msg20638 (view) Author: bf Date: 2019-01-24.15:46:35
Two more patches that help prepare V3 integration but make sense independently.

2 patches for repository http://darcs.net/screened:

patch b9370f3f3bad1bc10c10a8558c192ce3e8465d2f
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Jan 24 14:53:42 CET 2019
  * add class IdEq2 to Darcs.Patch.Ident
  
  This allows a faster equality test for FLs of patches with identity.

patch ea200408863e1030fea867ac33f845f080f40eff
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Jan 23 19:42:50 CET 2019
  * annotate all uses of anonymous with comments
  
  Whenever we call anonymous to construct a Named patch we must now check
  that we don't accidentally store patches that result from merging them
  with normal patches.
Attachments
History
Date User Action Args
2019-01-24 11:00:43bfcreate
2019-01-24 11:15:25bfsetstatus: needs-screening -> needs-review
2019-01-24 15:46:36bfsetfiles: + patch-preview.txt, add-class-ideq2-to-darcs_patch_ident.dpatch, unnamed
messages: + msg20638