darcs

Patch 1796 don't offer already depended on patches with --ask-deps

Title don't offer already depended on patches with --ask-deps
Superseder Nosy List bf
Related Issues
Status needs-screening Assigned To
Milestone

Created on 2019-01-24.20:01:22 by bf, last changed 2019-01-24.20:01:22 by bf.

Files
File name Status Uploaded Type Edit Remove
don_t-offer-already-depended-on-patches-with-__ask_deps.dpatch bf, 2019-01-24.20:01:22 application/x-darcs-patch
patch-preview.txt bf, 2019-01-24.20:01:22 text/x-darcs-patch
unnamed bf, 2019-01-24.20:01:22 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg20646 (view) Author: bf Date: 2019-01-24.20:01:22
I am /not/ screening this one for the moment because I think the current
behavior merits a bit of discussion. Another, perhaps better way to fix this
would be to introduce a change of behavior for --ask-deps so that, for
amend, it ignores the old dependencies instead of only adding to the
existing set. This would allow users to remove unwanted dependencies, which
is currently not possible except by unrecording and then recording again. If
we agree on this we should document the new behavior in the help text for
the amend command.

1 patch for repository http://darcs.net/screened:

patch 0942856223e2ffbcc0f4b38070c34a4bdb432e15
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Jan 24 20:34:57 CET 2019
  * don't offer already depended on patches with --ask-deps
  
  This reverts an unintended behavior change introduced by the fix for
  issue2618: the patches we already explicitly depend on are offered again.
  This is done by adding the old dependencies to the anonymous patch before
  filtering out its dependencies.
Attachments
History
Date User Action Args
2019-01-24 20:01:22bfcreate