darcs

Patch 1803 expose the test harness runner and config for running ...

Title expose the test harness runner and config for running ...
Superseder Nosy List ganesh
Related Issues
Status accepted Assigned To
Milestone

Created on 2019-06-07.19:30:05 by ganesh, last changed 2019-06-11.22:32:38 by bf.

Files
File name Status Uploaded Type Edit Remove
expose-the-test-harness-runner-and-config-for-running-from-ghci.dpatch ganesh, 2019-06-07.19:30:05 application/x-darcs-patch
patch-preview.txt ganesh, 2019-06-07.19:30:05 text/x-darcs-patch
unnamed ganesh, 2019-06-07.19:30:05 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg20698 (view) Author: ganesh Date: 2019-06-07.19:30:05
this makes it easier to work with the test suite from ghci
1 patch for repository darcs-unstable@darcs.net:screened:

patch 0522840df53997067aca1af626ef5550d8693982
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Thu Jun  6 23:35:39 BST 2019
  * expose the test harness runner and config for running from ghci
Attachments
msg20726 (view) Author: bf Date: 2019-06-11.20:20:49
I am fine with the idea of the patch (as expressed in its name) but I 
don't quite get the reason for renaming defaultConfig to 
defaultConfigAnn.
msg20733 (view) Author: ganesh Date: 2019-06-11.22:16:03
To be honest I can't quite remember either - this change came from 
my branch for Darcs.Commands.UI.Test which is 4 years old and I also
just assumed from the name of the patch that it was likely to be 
useful.

I'm guessing from the code that I needed access to defaultConfig
as opposed to defaultConfigAnn, and thought the new naming scheme
was more appropriate. From the types, defaultConfigAnn is an
Annotated configuration whereas defaultConfig is the same thing
without annotations.
msg20734 (view) Author: bf Date: 2019-06-11.22:32:37
I looked a bit closer at the changes. Yes, the rename makes sense, 
given that you expose another value that better deserves this name.
History
Date User Action Args
2019-06-07 19:30:05ganeshcreate
2019-06-08 19:34:47ganeshsetstatus: needs-screening -> needs-review
2019-06-11 20:20:49bfsetmessages: + msg20726
2019-06-11 22:16:04ganeshsetmessages: + msg20733
2019-06-11 22:32:38bfsetstatus: needs-review -> accepted
messages: + msg20734