darcs

Patch 1816 fix a (serious!) bug in instance Apply (RL p)

Title fix a (serious!) bug in instance Apply (RL p)
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone

Created on 2019-06-12.11:38:58 by bf, last changed 2019-06-14.13:34:39 by ganesh.

Files
File name Status Uploaded Type Edit Remove
fix-a-_serious__-bug-in-instance-apply-_rl-p_.dpatch bf, 2019-06-12.11:38:58 application/x-darcs-patch
patch-preview.txt bf, 2019-06-12.11:38:58 text/x-darcs-patch
unnamed bf, 2019-06-12.11:38:58 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg20749 (view) Author: bf Date: 2019-06-12.11:38:58
I guess this is late fallout from my long ago refactor that changed the
argument order for the patch sequencing operators. This isn't covered by
unit tests since they only use FLs. And the type checker cannot flag this
error because apply is monadic and Trees aren't tagged with witnesses.

1 patch for repository /home/ben/src/darcs/sent:

patch 8c3031c28048eb2d14af5eb26ad96cb57d33d69c
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Mar  6 11:40:28 CET 2019
  * fix a (serious!) bug in instance Apply (RL p)
Attachments
msg20791 (view) Author: ganesh Date: 2019-06-14.12:07:33
I tried changing this code to an error, and the entire shell test
suite passes too. So I guess we dodged the bullet because it's
never actually used anywhere.
History
Date User Action Args
2019-06-12 11:38:58bfcreate
2019-06-12 12:32:55bfsetstatus: needs-screening -> needs-review
2019-06-14 12:07:33ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg20791
2019-06-14 13:34:39ganeshsetstatus: accepted-pending-tests -> accepted