Patch 1818 issue1442 has been resolved some time ago (and 3 more)

Title issue1442 has been resolved some time ago (and 3 more)
Superseder Nosy List bf
Related Issues
Status accepted Assigned To

Created on 2019-06-12.17:47:07 by bf, last changed 2019-08-06.14:36:40 by ganesh.

File name Status Uploaded Type Edit Remove
issue1442-has-been-resolved-some-time-ago.dpatch bf, 2019-06-12.17:47:07 application/x-darcs-patch
issue1442-test-doesn_t-work-on-windows.dpatch ganesh, 2019-08-06.14:34:40 application/x-darcs-patch
patch-preview.txt bf, 2019-06-12.17:47:07 text/x-darcs-patch
patch-preview.txt ganesh, 2019-08-06.14:34:40 text/x-darcs-patch
unnamed bf, 2019-06-12.17:47:07 text/plain
unnamed ganesh, 2019-08-06.14:34:40 text/plain
See mailing list archives for discussion on individual patches.
msg20762 (view) Author: bf Date: 2019-06-12.17:47:07
Test script and issue cleanup.

4 patches for repository /home/ben/src/darcs/sent:

patch ca7780c8aa54bbe66cfe3a68db348a9363e86d7c
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Jun 12 17:38:42 CEST 2019
  * issue1442 has been resolved some time ago

patch 6587ffc9d6d2eb120e39f9d30ef0d6595e734dff
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Jun 12 17:52:15 CEST 2019
  * test for issue2275 no longer fails

patch 3113fff08bdd62741bc9d46292333bc44be242e6
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Jun 12 17:54:02 CEST 2019
  * test for issue2293 no longer fails

patch 399afb6d3993c0281fa20d5ace212dc9c1000ee4
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Jun 12 18:02:32 CEST 2019
  * issue2614 has been resolved
  It has been fixed by
    patch 9dfd9ea8480ced1f5bf88491c51d31b622bd6a43
      * revert partitionRL to its former state, remove partitionRL'
  Also, for darcs-1 repos it failed for the wrong reason, namely because we
  push a conflicting patch (it does not conflict for darcs-2 because of
  Duplicates) so we allow pushing conflicts to the target repo.
msg20788 (view) Author: ganesh Date: 2019-06-14.11:50:59
OK, assuming the tests are all ok on Windows.
msg20805 (view) Author: bf Date: 2019-06-14.17:46:11
> OK, assuming the tests are all ok on Windows.

It would be nice if you could check that. I looked at the issue in our
tracker and did not find any recent comments, in contrast to some other
encoding issues that you expressly noted prevail on windows or even
regressed. At some point we should get together to make an effort to
sort out these issues. It can't be /that/ hard.
msg21043 (view) Author: ganesh Date: 2019-08-06.14:34:40
Turns out the issue1442 test doesn't work on Windows.
I won't investigate that for now, so I'm just skipping it there.

Will self-accept along with pushing the original patching
enabling the issue1442 test.

1 patch for repository darcs-unstable@darcs.net:screened:

patch c041a3557da9c9fdb986208dd17c394878af6c44
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Tue Aug  6 13:24:42 BST 2019
  * issue1442 test doesn't work on Windows
Date User Action Args
2019-06-12 17:47:07bfcreate
2019-06-12 17:54:42bfsetstatus: needs-screening -> needs-review
2019-06-14 11:50:59ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg20788
2019-06-14 17:46:11bfsetmessages: + msg20805
2019-08-06 14:34:40ganeshsetfiles: + patch-preview.txt, issue1442-test-doesn_t-work-on-windows.dpatch, unnamed
messages: + msg21043
2019-08-06 14:36:40ganeshsetstatus: accepted-pending-tests -> accepted