darcs

Patch 1833 tests: eliminate two windows checks

Title tests: eliminate two windows checks
Superseder Nosy List bf
Related Issues
Status in-discussion Assigned To
Milestone

Created on 2019-06-15.10:33:26 by bf, last changed 2019-08-06.15:13:53 by ganesh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bf, 2019-06-15.10:33:26 text/x-darcs-patch
tests_-eliminate-two-windows-checks.dpatch bf, 2019-06-15.10:33:26 application/x-darcs-patch
unnamed bf, 2019-06-15.10:33:26 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg20829 (view) Author: bf Date: 2019-06-15.10:33:26
Not screening this one until Ganesh gives okay. Saw this when I looked at
the test scripts for 'darcs test' that you pointed me to.

1 patch for repository http://darcs.net/screened:

patch 89cc7095263d3fef2b84971c6ccfa641bc948851
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Jun 14 13:28:09 CEST 2019
  * tests: eliminate two windows checks
  
  I think we /can/ run tests on windows. And if not, this should be part of
  tests/lib.
Attachments
msg21044 (view) Author: ganesh Date: 2019-08-06.15:13:53
Sorry for the delay with this one. The two tests fail on Windows
with this change.

For issue538, it's probably because a test script
can't be a shell script. Even though the test harness uses shell
scripts, darcs itself just invokes things as native tools.

For trackdown-bisect I think it's the same thing in that the
test-cmd is 'grep', and the native one on Windows doesn't behave
like the Unix one.

We should at least just use abort_windows for these though.
History
Date User Action Args
2019-06-15 10:33:26bfcreate
2019-08-06 15:13:53ganeshsetstatus: needs-screening -> in-discussion
messages: + msg21044