darcs

Patch 1852 turn fancyPrinters into an IO action (and 1 more)

Title turn fancyPrinters into an IO action (and 1 more)
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone

Created on 2019-07-16.10:40:19 by bf, last changed 2019-07-28.19:38:59 by ganesh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bf, 2019-07-16.10:40:18 text/x-darcs-patch
turn-fancyprinters-into-an-io-action.dpatch bf, 2019-07-16.10:40:18 application/x-darcs-patch
unnamed bf, 2019-07-16.10:40:18 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg20950 (view) Author: bf Date: 2019-07-16.10:40:18
2 patches for repository http://darcs.net/screened:

patch 89f2ddd59c03d54ae656930206e02b80031c6731
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Jun 19 22:06:47 CEST 2019
  * turn fancyPrinters into an IO action
  
  This is what it actually is, via getPolicy. The unsafePerformIO was
  perfunctory, since fancyPrinters (almost) always gets passed to a real IO
  action that does the actual printing. The only exceptions are when we use it
  for tracing and in the harness when converting our TestResult to HUnit or
  QuickCheck. Consequently showDoc has been renamed unsafeRenderStringColored
  (to discourage its use) and a function debugDoc added.

patch 0477caae257162b34f54bfba9a75f682e54375c3
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Jun 19 22:38:13 CEST 2019
  * remove env var DARCS_DO_COLOR_LINES
  
  If the user wants colored output we should go all the way and not require
  them to set yet another configuration variable to achieve that. On the other
  hand, if they can't see colors or don't have actual colors in their terminal
  and thus set DARCS_ALTERNATIVE_COLOR then we should not color hunk lines
  since we have no alternative rendering for them.
Attachments
msg20991 (view) Author: ganesh Date: 2019-07-28.14:15:31
> Author: Ben Franksen <ben.franksen@online.de>
> Date:   Wed Jun 19 22:06:47 CEST 2019
>   * turn fancyPrinters into an IO action
Nice cleanup

> patch 0477caae257162b34f54bfba9a75f682e54375c3
> Author: Ben Franksen <ben.franksen@online.de>
> Date:   Wed Jun 19 22:38:13 CEST 2019
>   * remove env var DARCS_DO_COLOR_LINES

Fine
History
Date User Action Args
2019-07-16 10:40:19bfcreate
2019-07-19 08:49:41bfsetstatus: needs-screening -> needs-review
2019-07-28 14:15:31ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg20991
2019-07-28 19:38:59ganeshsetstatus: accepted-pending-tests -> accepted