darcs

Patch 1865 remove our own optimisation settings in darcs.cabal

Title remove our own optimisation settings in darcs.cabal
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone

Created on 2019-08-11.16:06:48 by bf, last changed 2019-08-13.00:56:05 by ganesh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bf, 2019-08-11.16:06:48 text/x-darcs-patch
remove-our-own-optimisation-settings-in-darcs_cabal.dpatch bf, 2019-08-11.16:06:48 application/x-darcs-patch
unnamed bf, 2019-08-11.16:06:48 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg21075 (view) Author: bf Date: 2019-08-11.16:06:48
Sending this for discussion. It works fine for me...

1 patch for repository http://darcs.net/screened:

patch 8f3b7bb7685d16003ba26050397b3022d0427119
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Jul 19 17:55:14 CEST 2019
  * remove our own optimisation settings in darcs.cabal
  
  Letting cabal be aware of optimisation makes it easier to switch between
  optimised and unoptimised builds, since cabal nowadays puts unoptimised
  builds in a separate directory.
  I tested with a number CPU-intensive test runs (darcs-test -t conflict) that
  this causes no performance regressions: the default optimisation level
  chosen by cabal (-O1) gives the same or better results than the -O2 we
  passed explicitly.
Attachments
msg21077 (view) Author: ganesh Date: 2019-08-11.18:28:23
I'm in favour of doing this. Our cabal setup is dragging a lot of
legacy with it and any simplifications are a good thing.
msg21088 (view) Author: bf Date: 2019-08-12.15:31:26
Thanks, screening it now.
History
Date User Action Args
2019-08-11 16:06:48bfcreate
2019-08-11 18:28:23ganeshsetmessages: + msg21077
2019-08-12 15:31:27bfsetstatus: needs-screening -> needs-review
messages: + msg21088
2019-08-12 22:51:40ganeshsetstatus: needs-review -> accepted-pending-tests
2019-08-13 00:56:05ganeshsetstatus: accepted-pending-tests -> accepted