Patch 1868 replace commenting out with if False in ... (and 1 more)

Title replace commenting out with if False in ... (and 1 more)
Superseder Nosy List ganesh
Related Issues
Status accepted Assigned To

Created on 2019-08-12.13:39:28 by ganesh, last changed 2019-08-20.15:17:12 by bf.

File name Status Uploaded Type Edit Remove
patch-preview.txt ganesh, 2019-08-12.13:39:28 text/x-darcs-patch
replace-commenting-out-with-if-false-in-qc_v1p1.dpatch ganesh, 2019-08-12.13:39:28 application/x-darcs-patch
unnamed ganesh, 2019-08-12.13:39:28 text/plain
See mailing list archives for discussion on individual patches.
msg21082 (view) Author: ganesh Date: 2019-08-12.13:39:28
Some small cleanups for the test harness

Ben, let me know if you have anything pending that would
conflict annoyingly, otherwise I'll push to screened soon.

2 patches for repository darcs-unstable@darcs.net:screened:

patch b9f905c283113fecf2577520182efdf8c55dabf8
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Mon Aug 12 14:30:57 BST 2019
  * replace commenting out with if False in qc_V1P1
  Predictably the code had rotted a bit, but it looks like
  from history that commute_properties is now pair_properties

patch e3458e21393e36c2c29e8f560f4a275a6cc584f3
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Mon Aug 12 14:41:26 BST 2019
  * replace some undefineds with TypeApplications
msg21084 (view) Author: bf Date: 2019-08-12.14:32:58
No conflicts, but the bundle actually depends on patch1862, so I'll screen them both now.
msg21146 (view) Author: bf Date: 2019-08-20.15:17:12
These are obvious improvements to the test suite. Explicit TypeApplication  improves readability and more directly expresses our intent.
Date User Action Args
2019-08-12 13:39:28ganeshcreate
2019-08-12 14:32:58bfsetstatus: needs-screening -> needs-review
messages: + msg21084
2019-08-20 15:17:12bfsetstatus: needs-review -> accepted
messages: + msg21146