darcs

Patch 1875 remove redundant Functor superclass cons... (and 5 more)

Title remove redundant Functor superclass cons... (and 5 more)
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone

Created on 2019-08-15.07:30:49 by bf, last changed 2019-08-26.15:24:23 by bf.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bf, 2019-08-15.07:30:49 text/x-darcs-patch
remove-redundant-functor-superclass-constraints-when-we-already-have-monad.dpatch bf, 2019-08-15.07:30:49 application/x-darcs-patch
unnamed bf, 2019-08-15.07:30:49 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg21106 (view) Author: bf Date: 2019-08-15.07:30:49
More or less trivial fixes and cleanups.

6 patches for repository http://darcs.net/screened:

patch 86a4a97ab80439823423dfcd83bcf7a74966b9a1
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Aug  2 11:59:07 CEST 2019
  * remove redundant Functor superclass constraints when we already have Monad

patch 084d6aedbfde804973f7319fbdef1aed53cd32c7
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Aug  2 18:30:34 CEST 2019
  * replace parseFlags with operator '?'

patch c73c6219b04515b3f417af06d6a4d99140dc3327
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Aug  2 19:24:59 CEST 2019
  * fix layout in parts of D.P.Rebase.Viewing and D.UI.Commands.Rebase
  
  This is to avoid extremely long code lines.

patch d650a90f25acb99431a1c21c5389276cf7bb3b85
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Aug  2 19:33:09 CEST 2019
  * eliminate a few redundant constraints in D.P.Rebase.Fixup

patch 00790009490c673aa502d94e021463fad0bb101c
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Aug  4 23:39:45 CEST 2019
  * fix call to anchorPath in Darcs.Repository.Diff.treeDiff

patch 0381704cc17d0c8f9e79471b96c8f6b561673d00
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Aug  8 10:29:58 CEST 2019
  * remove unused function filterFilePaths
Attachments
msg21178 (view) Author: ganesh Date: 2019-08-25.15:50:46
> * fix call to anchorPath in Darcs.Repository.Diff.treeDiff

It took me a little while to work out why this bug didn't cause an
obvious problem. In the end, filetypeFunction in 
Darcs.Repository.Prefs just does a regex match against a list
of things that should be considered binary. And presumably
most regexes don't care about a leading " /" or not.

In theory we could probably write a test for this but I doubt it's
worth the effort.

Rest all look fine too.
msg21203 (view) Author: ganesh Date: 2019-08-26.12:56:08
>  * fix layout in parts of D.P.Rebase.Viewing and D.UI.Commands.Rebase

FWIW this turns out to have a type error, fixed by patch1877.
msg21209 (view) Author: bf Date: 2019-08-26.15:14:41
>>  * fix layout in parts of D.P.Rebase.Viewing and D.UI.Commands.Rebase
> 
> FWIW this turns out to have a type error, fixed by patch1877.

Can you double-check that this isn't caused by a patch that is not yet
in screened? Or simply send a context file? I haven't seen any build
errors on screened for a very long time and I usually do at least a
build for every bundle I send, more often run the full test suite.
msg21210 (view) Author: bf Date: 2019-08-26.15:24:23
>>>  * fix layout in parts of D.P.Rebase.Viewing and D.UI.Commands.Rebase
>>
>> FWIW this turns out to have a type error, fixed by patch1877.
> 
> Can you double-check that this isn't caused by a patch that is not yet
> in screened? Or simply send a context file? I haven't seen any build
> errors on screened for a very long time and I usually do at least a
> build for every bundle I send, more often run the full test suite.

Forget it, I misread the patch ID. Thought you were talking about
patch1887 which isn't screened yet.

This is probably a rebase glitch, sorry about that. BTW, I have the
feeling that sometimes during rebase explicit dependencies get lost,
despite the warning that darcs issues. Perhaps we should make the
warning more prominent i.e. display in red like conflicts?
History
Date User Action Args
2019-08-15 07:30:49bfcreate
2019-08-15 07:33:03bfsetstatus: needs-screening -> needs-review
2019-08-25 15:50:47ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg21178
2019-08-26 12:56:08ganeshsetmessages: + msg21203
2019-08-26 14:40:40ganeshsetstatus: accepted-pending-tests -> accepted
2019-08-26 15:14:42bfsetmessages: + msg21209
2019-08-26 15:24:23bfsetmessages: + msg21210