darcs

Patch 1876 turn an error call into a proper failure when cloning

Title turn an error call into a proper failure when cloning
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone

Created on 2019-08-15.07:38:30 by bf, last changed 2019-08-26.14:40:38 by ganesh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bf, 2019-08-15.07:38:30 text/x-darcs-patch
turn-an-error-call-into-a-proper-failure-when-cloning.dpatch bf, 2019-08-15.07:38:30 application/x-darcs-patch
unnamed bf, 2019-08-15.07:38:30 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg21107 (view) Author: bf Date: 2019-08-15.07:38:30
This one may need careful review, though I am pretty confident the refactors
are sound.

1 patch for repository http://darcs.net/screened:

patch 71465505ff2739ec188389590751f0d82ade6dc1
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Aug  2 19:06:48 CEST 2019
  * turn an error call into a proper failure when cloning
  
  This patch also cleans up the surrounding code:
   * find uncommon patches only once instead of twice
   * replace repeated calls to lengthFL with a let-bound variable
   * rename some variables
   * remove unneeded calls to hopefully and effect
  Regarding the last change, note that (apply . effect) is strictly inferior
  to the plain apply, since the latter is hopefully optimized via applyPrimFL.
Attachments
msg21179 (view) Author: ganesh Date: 2019-08-25.15:54:40
Looks good
History
Date User Action Args
2019-08-15 07:38:30bfcreate
2019-08-15 07:39:03bfsetstatus: needs-screening -> needs-review
2019-08-25 15:54:40ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg21179
2019-08-26 14:40:38ganeshsetstatus: accepted-pending-tests -> accepted