darcs

Patch 1877 suspend reify: give reified fixup patches a real author

Title suspend reify: give reified fixup patches a real author
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone

Created on 2019-08-15.07:40:26 by bf, last changed 2019-08-26.14:40:35 by ganesh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bf, 2019-08-15.07:40:26 text/x-darcs-patch
suspend-reify_-give-reified-fixup-patches-a-real-author.dpatch bf, 2019-08-15.07:40:26 application/x-darcs-patch
unnamed bf, 2019-08-15.07:40:26 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg21108 (view) Author: bf Date: 2019-08-15.07:40:26
I think this is a strict improvement.

1 patch for repository http://darcs.net/screened:

patch dfb78642e1f57e824bf74fb4394dc20db1251131
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Aug  2 19:51:08 CEST 2019
  * suspend reify: give reified fixup patches a real author
  
  Instead of "Invalid <invalid@invalid>" we now call getAuthor and pass that
  down to reifyRebaseSelect.
Attachments
msg21109 (view) Author: bf Date: 2019-08-15.07:42:20
OMG, sorry for botching the patch name! It should say 'rebase reify' 
of course.
msg21180 (view) Author: ganesh Date: 2019-08-25.15:56:41
Makes sense.

I originally added 'reify' and 'inject' just as a way to make it
easier to muck around with rebase internals. If either is evolving 
towards being a proper command we could also unhide them and improve
the help.
msg21188 (view) Author: bf Date: 2019-08-25.22:34:52
Am 25.08.19 um 17:56 schrieb Ganesh Sittampalam:
> I originally added 'reify' and 'inject' just as a way to make it
> easier to muck around with rebase internals. If either is evolving 
> towards being a proper command we could also unhide them and improve
> the help.

I don't think reify should be a proper command.

This change fell out of a half-hearted effort to implement an
unsuspend-reify command to get rid of the hack I needed to add to the
force-commute for V3 and also improve on the safety and usability of
unsuspend. This was more difficult than I expected so I temporarily
abandoned it.
History
Date User Action Args
2019-08-15 07:40:26bfcreate
2019-08-15 07:42:20bfsetstatus: needs-screening -> needs-review
messages: + msg21109
2019-08-25 15:56:41ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg21180
2019-08-25 22:34:53bfsetmessages: + msg21188
2019-08-26 14:40:35ganeshsetstatus: accepted-pending-tests -> accepted