darcs

Patch 1894 add the darcs executable as a build-tool-depend of dar...

Title add the darcs executable as a build-tool-depend of dar...
Superseder Nosy List ganesh
Related Issues
Status accepted Assigned To
Milestone

Created on 2019-08-26.14:38:46 by ganesh, last changed 2019-08-26.20:47:22 by bf.

Files
File name Status Uploaded Type Edit Remove
add-the-darcs-executable-as-a-build_tool_depend-of-darcs_test.dpatch ganesh, 2019-08-26.14:38:46 application/x-darcs-patch
patch-preview.txt ganesh, 2019-08-26.14:38:46 text/x-darcs-patch
unnamed ganesh, 2019-08-26.14:38:46 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg21206 (view) Author: ganesh Date: 2019-08-26.14:38:46
1 patch for repository darcs-unstable@darcs.net:screened:

patch e412fa5975365a2ab355ad11a29eca4dc59308dc
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Mon Aug 26 15:40:23 BST 2019
  * add the darcs executable as a build-tool-depend of darcs-test
  
  This means we can use cabal to run the tests and be sure that the
  darcs executable they test will be up to date.
  
  Without this change, 'cabal v2-run test:darcs-test'
  (needed to run the harness with custom options) doesn't build the
  executable.
Attachments
msg21216 (view) Author: bf Date: 2019-08-26.19:52:58
> patch e412fa5975365a2ab355ad11a29eca4dc59308dc
> Author: Ganesh Sittampalam <ganesh@earth.li>
> Date:   Mon Aug 26 15:40:23 BST 2019
>   * add the darcs executable as a build-tool-depend of darcs-test
>   
>   This means we can use cabal to run the tests and be sure that the
>   darcs executable they test will be up to date.
>   
>   Without this change, 'cabal v2-run test:darcs-test'
>   (needed to run the harness with custom options) doesn't build the
>   executable.

Looks good to me. Any special reason not to screen it?
msg21219 (view) Author: ganesh Date: 2019-08-26.20:35:36
I did screen it - just forgot to update the status
History
Date User Action Args
2019-08-26 14:38:46ganeshcreate
2019-08-26 19:52:59bfsetmessages: + msg21216
2019-08-26 20:35:36ganeshsetstatus: needs-screening -> needs-review
messages: + msg21219
2019-08-26 20:47:22bfsetstatus: needs-review -> accepted