darcs

Patch 1912 remove OneIndex from haveNonrangeMatch (and 3 more)

Title remove OneIndex from haveNonrangeMatch (and 3 more)
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone

Created on 2019-09-09.09:43:07 by bf, last changed 2019-09-18.22:50:53 by ganesh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bf, 2019-09-09.09:43:06 text/x-darcs-patch
remove-oneindex-from-havenonrangematch.dpatch bf, 2019-09-09.09:43:06 application/x-darcs-patch
unnamed bf, 2019-09-09.09:43:06 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg21397 (view) Author: bf Date: 2019-09-09.09:43:06
4 patches for repository http://darcs.net/screened:

patch 7aa82147dac5338031790d08a7b10c3062266da4
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Sep  9 10:09:13 CEST 2019
  * remove OneIndex from haveNonrangeMatch
  
  While in principle this would be a valid nonrange matcher, in practice we
  can (and do) only use it as a patchSetMatch. This is because the index of a
  patch in the current ordering of a repo cannot be read off the patch itself.

patch 16c01c0ab166876790b5cae7f07eeca1df0cc860
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Sep  9 10:23:30 CEST 2019
  * cleanup exports of Darcs.Patch.Match
  
  This removes nonrangeMatcherIsTag which is nowhere used and also removes
  matchParser, nonrangeMatcher, and applyNInv from the exports since they are
  used only internally.

patch be16ab83b8490643b807b45d2e5a764950e0ceab
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Sep  9 10:53:06 CEST 2019
  * document patchSetMatches in the haddocks for Darcs.Patch.Match

patch a49f3a254e688204df79d6dba600796bc82f52a0
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Sep  9 11:03:24 CEST 2019
  * cleanup definition of MatchFlag
Attachments
msg21451 (view) Author: ganesh Date: 2019-09-18.19:58:41
>  * remove OneIndex from haveNonrangeMatch

Fine, assuming the tests pass this looks like an improvement to the
readability of 'haveNonrangeMatch'.

>  * cleanup exports of Darcs.Patch.Match

Fine

>  * document patchSetMatches in the haddocks for Darcs.Patch.Match

Looks useful, thanks.

>   * cleanup definition of MatchFlag

Fine
History
Date User Action Args
2019-09-09 09:43:07bfcreate
2019-09-09 09:43:48bfsetstatus: needs-screening -> needs-review
2019-09-18 19:58:41ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg21451
2019-09-18 22:50:53ganeshsetstatus: accepted-pending-tests -> accepted