darcs

Patch 1916 rename D.P.Rebase.Container to D.P.Rebase.Suspended

Title rename D.P.Rebase.Container to D.P.Rebase.Suspended
Superseder Nosy List ganesh
Related Issues
Status accepted Assigned To
Milestone

Created on 2019-09-14.15:37:00 by ganesh, last changed 2019-09-20.12:02:58 by bf.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt ganesh, 2019-09-14.15:37:00 text/x-darcs-patch
rename-d_p_rebase_container-to-d_p_rebase_suspended.dpatch ganesh, 2019-09-14.15:37:00 application/x-darcs-patch
unnamed ganesh, 2019-09-14.15:37:00 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg21412 (view) Author: ganesh Date: 2019-09-14.15:37:00
extracting an orthogonal cleanup from patch1911

1 patch for repository darcs-unstable@darcs.net:screened:

patch 930c67427998afb9099a5dd479482e087d5b4ef3
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sat Sep 14 16:38:26 BST 2019
  * rename D.P.Rebase.Container to D.P.Rebase.Suspended
  
  The module primarily contains the Suspended type and code
  to manipulate it.
Attachments
msg21415 (view) Author: bf Date: 2019-09-14.18:46:29
> 1 patch for repository darcs-unstable@darcs.net:screened:
> 
> patch 930c67427998afb9099a5dd479482e087d5b4ef3
> Author: Ganesh Sittampalam <ganesh@earth.li>
> Date:   Sat Sep 14 16:38:26 BST 2019
>   * rename D.P.Rebase.Container to D.P.Rebase.Suspended
>   
>   The module primarily contains the Suspended type and code
>   to manipulate it.

FWIW, I find the module name Container quite fitting. It describes
clearly what this module gives us: the one big rebase patch that
contains all the patches to be edited and their fixups.
msg21416 (view) Author: ganesh Date: 2019-09-14.18:59:13
> FWIW, I find the module name Container quite fitting. It describes
> clearly what this module gives us: the one big rebase patch that
> contains all the patches to be edited and their fixups.

Ah, I thought it'd be uncontroversial so already screened it (just forgot
to update the status). I had the same reason for giving it that name to 
begin with, but in retrospect it seemed like it was just gratuitously
making the code harder to explore.
msg21426 (view) Author: bf Date: 2019-09-15.11:42:17
>> FWIW, I find the module name Container quite fitting. It describes
>> clearly what this module gives us: the one big rebase patch that
>> contains all the patches to be edited and their fixups.
> 
> Ah, I thought it'd be uncontroversial so already screened it (just forgot
> to update the status). I had the same reason for giving it that name to 
> begin with, but in retrospect it seemed like it was just gratuitously
> making the code harder to explore.

I understand, but I'd rather have renamed the patch type Suspended to
RebaseContainer (and then perhaps renamed RebaseItem to Suspended). This
implies a lot more churn though, as now some of the function names may
now be named confusingly, so we'd have to rename them, too, etc etc.

My objection stands but it's really not a big deal and I can live
perfectly well with the new module name.
History
Date User Action Args
2019-09-14 15:37:00ganeshcreate
2019-09-14 18:46:29bfsetmessages: + msg21415
2019-09-14 18:59:13ganeshsetstatus: needs-screening -> needs-review
messages: + msg21416
2019-09-15 11:42:17bfsetmessages: + msg21426
2019-09-20 12:02:58bfsetstatus: needs-review -> accepted