>> FWIW, I find the module name Container quite fitting. It describes
>> clearly what this module gives us: the one big rebase patch that
>> contains all the patches to be edited and their fixups.
>
> Ah, I thought it'd be uncontroversial so already screened it (just forgot
> to update the status). I had the same reason for giving it that name to
> begin with, but in retrospect it seemed like it was just gratuitously
> making the code harder to explore.
I understand, but I'd rather have renamed the patch type Suspended to
RebaseContainer (and then perhaps renamed RebaseItem to Suspended). This
implies a lot more churn though, as now some of the function names may
now be named confusingly, so we'd have to rename them, too, etc etc.
My objection stands but it's really not a big deal and I can live
perfectly well with the new module name.
|