Patch 1925: minor refactor and layout cleanup of D.U... (and 2 more) - Darcs bug tracker

Title	minor refactor and layout cleanup of D.U... (and 2 more)
Superseder		Nosy List	bfrk
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2019-09-20.14:42:22 by bfrk, last changed 2019-09-25.21:05:21 by ganesh.

Files
File name	Status	Uploaded	Type	Edit	Remove
minor-refactor-and-layout-cleanup-of-d_ui_selectchange_textselect.dpatch		bfrk, 2019-09-20.15:11:57	application/x-darcs-patch
patch-preview.txt		bfrk, 2019-09-20.15:11:57	text/x-darcs-patch
unnamed		bfrk, 2019-09-20.15:11:57	text/plain

See mailing list archives for discussion on individual patches.

Messages
msg21485 (view)	Author: bfrk	Date: 2019-09-20.14:42:21
This bundle is a more thorough follow-up to my renamings in patch1920 that raised some eyebrows. 3 patches for repository http://darcs.net/screened: patch 8f2ac987eddfe731ba92b0096c7c3a9631c1b1aa Author: Ben Franksen <ben.franksen@online.de> Date: Fri Sep 20 15:58:56 CEST 2019 * minor refactor and layout cleanup of D.UI.SelectChange.textSelect patch 7f8162bf3aaf6a958ccdd7ff58ca87ddf8ff62f9 Author: Ben Franksen <ben.franksen@online.de> Date: Fri Sep 20 16:41:30 CEST 2019 * factor out initialSelectionState This also removes the (unused) prim splitter from runInteractive in the whatsnew command. patch 814d2547aa1f25249f2cfff43a483a01426c8fab Author: Ben Franksen <ben.franksen@online.de> Date: Fri Sep 20 16:44:37 CEST 2019 * rename data types and functions that support patch selection This renames Context to Config except for InteractiveSelectionContext which is renamed to InteractiveSelectionState. Attachments minor-refactor-and-layout-cleanup-of-d_ui_selectchange_textselect.dpatch patch-preview.txt unnamed
msg21491 (view)	Author: bfrk	Date: 2019-09-20.15:11:57
Oops. The last patch was recorded incomplete. Resending to fix that. 3 patches for repository http://darcs.net/screened: patch 8f2ac987eddfe731ba92b0096c7c3a9631c1b1aa Author: Ben Franksen <ben.franksen@online.de> Date: Fri Sep 20 15:58:56 CEST 2019 * minor refactor and layout cleanup of D.UI.SelectChange.textSelect patch 7f8162bf3aaf6a958ccdd7ff58ca87ddf8ff62f9 Author: Ben Franksen <ben.franksen@online.de> Date: Fri Sep 20 16:41:30 CEST 2019 * factor out initialSelectionState This also removes the (unused) prim splitter from runInteractive in the whatsnew command. patch 8961acc08f181ef121ae54c4c96160f1f6e33457 Author: Ben Franksen <ben.franksen@online.de> Date: Fri Sep 20 17:03:25 CEST 2019 * rename data types and functions that support patch selection This renames Context to Config except for InteractiveSelectionContext which is renamed to InteractiveSelectionState. Attachments minor-refactor-and-layout-cleanup-of-d_ui_selectchange_textselect.dpatch patch-preview.txt unnamed
msg21511 (view)	Author: bfrk	Date: 2019-09-21.10:35:10
I hope this isn't interfering too badly with your rebase WIP. If not I would like to screen this.
msg21517 (view)	Author: ganesh	Date: 2019-09-21.13:32:40
Screening it is fine, I don't think there'll be any major conflicts
msg21594 (view)	Author: ganesh	Date: 2019-09-25.19:04:10
Looks good

History
Date	User	Action	Args
2019-09-20 14:42:22	bfrk	create
2019-09-20 15:11:58	bfrk	set	files: + patch-preview.txt, minor-refactor-and-layout-cleanup-of-d_ui_selectchange_textselect.dpatch, unnamed messages: + msg21491
2019-09-20 15:12:47	bfrk	set	files: - minor-refactor-and-layout-cleanup-of-d_ui_selectchange_textselect.dpatch
2019-09-20 15:12:55	bfrk	set	files: - patch-preview.txt
2019-09-20 15:12:58	bfrk	set	files: - unnamed
2019-09-21 10:35:10	bfrk	set	messages: + msg21511
2019-09-21 13:32:40	ganesh	set	messages: + msg21517
2019-09-21 14:32:35	bfrk	set	status: needs-screening -> needs-review
2019-09-25 19:04:10	ganesh	set	status: needs-review -> accepted-pending-tests messages: + msg21594
2019-09-25 21:05:21	ganesh	set	status: accepted-pending-tests -> accepted