Patch 1928: use genCommuteWhatWeCanRL to minimize bundles - Darcs bug tracker

Title	use genCommuteWhatWeCanRL to minimize bundles
Superseder		Nosy List	bfrk
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2019-09-20.14:55:46 by bfrk, last changed 2019-09-23.12:21:01 by bfrk.

Files
File name	Status	Uploaded	Type	Edit	Remove
patch-preview.txt		bfrk, 2019-09-20.14:55:46	text/x-darcs-patch
unnamed		bfrk, 2019-09-20.14:55:46	text/plain
use-gencommutewhatwecanrl-to-minimize-bundles.dpatch		bfrk, 2019-09-20.14:55:46	application/x-darcs-patch

See mailing list archives for discussion on individual patches.

Messages
msg21489 (view)	Author: bfrk	Date: 2019-09-20.14:55:46
...to complete the refactors of Darcs.Patch.Bundle. 1 patch for repository http://darcs.net/screened: patch 525fa613cb5f4be1b0e66b4a19cd6e62452336c5 Author: Ben Franksen <ben.franksen@online.de> Date: Fri Sep 20 00:39:02 CEST 2019 * use genCommuteWhatWeCanRL to minimize bundles Attachments patch-preview.txt unnamed use-gencommutewhatwecanrl-to-minimize-bundles.dpatch
msg21513 (view)	Author: bfrk	Date: 2019-09-21.10:45:04
> * use genCommuteWhatWeCanRL to minimize bundles I have not studied the previous implementation in depth to make sure the behavior is unchanged. Rather, using genCommuteWhatWeCanRL was the result of considering what it should do from first principles. I think what I did here is correct, but I'd like to get a second opinion before screening it.
msg21534 (view)	Author: ganesh	Date: 2019-09-22.19:33:01
The new logic makes sense and I think it's also equivalent to the old code. You can consider this reviewed once you do screen it.

History
Date	User	Action	Args
2019-09-20 14:55:46	bfrk	create
2019-09-21 10:45:04	bfrk	set	messages: + msg21513
2019-09-22 19:33:01	ganesh	set	messages: + msg21534
2019-09-23 12:21:01	bfrk	set	status: needs-screening -> accepted