darcs

Patch 1940 show selected patches in commuted form (and 1 more)

Title show selected patches in commuted form (and 1 more)
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone

Created on 2019-09-26.12:42:17 by bf, last changed 2019-09-27.11:51:15 by ganesh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bf, 2019-09-26.12:42:16 text/x-darcs-patch
show-selected-patches-in-commuted-form.dpatch bf, 2019-09-26.12:42:16 application/x-darcs-patch
unnamed bf, 2019-09-26.12:42:16 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg21608 (view) Author: bf Date: 2019-09-26.12:42:16
Separately following up on review of accepted patch1913.

2 patches for repository http://darcs.net/screened:

patch 0b4081405911535f2a5dfb70635b63164a628f03
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Sep 25 20:48:58 CEST 2019
  * show selected patches in commuted form
  
  This is a partial rollback of
  
  patch e6d8e6474da18a8195f3e1293fd96f7c03127de3
  Author: Ben Franksen <ben.franksen@online.de>
  Date:   Thu Sep 19 18:40:36 CEST 2019
    * possible fix for D.UI.SelectChanges.selected
  
  The behavior prior to the above patch was the one we actually want.

patch 30e6112c5dc8e3f39cb70500475ec9f68efc1930
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Sep 25 20:57:51 CEST 2019
  * remove getSelected by inlining it into printSelected
  
  This allows us to make a number of simplifications and avoid duplicate
  traversals of the selected patches.
Attachments
msg21632 (view) Author: ganesh Date: 2019-09-27.10:51:59
>   * show selected patches in commuted form

Fine

>  * remove getSelected by inlining it into printSelected

In general I'd prefer to keep logic separate from UI code -
for example imagine if we wanted to expose interactive selection 
from a different UI. But we don't actually know what API we'd
need then anyway, so this isn't a big deal.
History
Date User Action Args
2019-09-26 12:42:17bfcreate
2019-09-26 16:33:43bfsetstatus: needs-screening -> needs-review
2019-09-27 10:51:59ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg21632
2019-09-27 11:51:15ganeshsetstatus: accepted-pending-tests -> accepted