darcs

Patch 1959 option to disable graphviz

Title option to disable graphviz
Superseder Nosy List ganesh
Related Issues
Status accepted Assigned To
Milestone

Created on 2020-01-25.15:44:36 by ganesh, last changed 2020-02-15.22:06:25 by ganesh.

Files
File name Status Uploaded Type Edit Remove
option-to-disable-graphviz.dpatch dead ganesh, 2020-01-25.15:44:35 application/x-darcs-patch
option-to-disable-graphviz.dpatch bf, 2020-01-27.20:53:05 application/x-darcs-patch
option-to-disable-graphviz_0.dpatch dead bf, 2020-01-27.12:50:38 application/x-darcs-patch
patch-preview.txt ganesh, 2020-01-25.15:44:35 text/x-darcs-patch
patch-preview.txt bf, 2020-01-27.12:50:38 text/x-darcs-patch
patch-preview.txt bf, 2020-01-27.20:53:05 text/x-darcs-patch
unnamed ganesh, 2020-01-25.15:44:35 text/plain
unnamed bf, 2020-01-27.12:50:38 text/plain
unnamed bf, 2020-01-27.20:53:05 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg21712 (view) Author: ganesh Date: 2020-01-25.15:44:35
For discussion for now.

The graphviz dependency is repeatedly problematic when trying to update to a new
GHC so having a quick way to defer dealing with it for a while will be helpful.

An alternative approach would simply be to drop "darcs show dependencies",
or just inline the bits of graphviz we need.

1 patch for repository darcs-unstable@darcs.net:screened:

patch 2c8715c83912daa42441e146b4c18f004b237319
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sat Jan 25 15:55:25 GMT 2020
  * option to disable graphviz
Attachments
msg21746 (view) Author: bf Date: 2020-01-27.12:50:38
I am fine with that. Attached is an amended version to restore the
dependency if the flag is set.

1 patch for repository http://darcs.net/screened:

patch 3e74f3e663c355b3e314b3bea6e7eee02b1012cf
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Mon Jan 27 14:00:55 CET 2020
  * option to disable graphviz
Attachments
msg21750 (view) Author: bf Date: 2020-01-27.20:53:05
Yet another amend: I didn't realize that the #define of HAVE_GRAPHVIZ is not
automatically done by cabal but must be done manually with a cpp-options
field.

1 patch for repository http://darcs.net/screened:

patch df9802529bf5fd188082d03103116ec8f7c7ee64
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Mon Jan 27 14:27:36 CET 2020
  * option to disable graphviz
Attachments
msg21751 (view) Author: bf Date: 2020-01-27.20:55:20
Screening my latest version now.
msg21753 (view) Author: ganesh Date: 2020-01-27.21:12:36
Thanks! From what I remember I did get it right initially, but
I must have screwed up when resolving some conflicts.
msg21821 (view) Author: ganesh Date: 2020-02-15.20:21:02
Looks fine (and is irrelevant given patch1969 anyway)
History
Date User Action Args
2020-01-25 15:44:36ganeshcreate
2020-01-25 15:46:13ganeshsetstatus: needs-screening -> in-discussion
2020-01-27 12:50:39bfsetfiles: + patch-preview.txt, option-to-disable-graphviz_0.dpatch, unnamed
messages: + msg21746
2020-01-27 20:53:05bfsetfiles: + patch-preview.txt, option-to-disable-graphviz.dpatch, unnamed
messages: + msg21750
2020-01-27 20:55:20bfsetstatus: in-discussion -> needs-review
messages: + msg21751
2020-01-27 21:12:36ganeshsetmessages: + msg21753
2020-02-15 20:21:02ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg21821
2020-02-15 22:06:25ganeshsetstatus: accepted-pending-tests -> accepted