darcs

Patch 1969 remove graphviz dependency by re-implementing show dependencies

Title remove graphviz dependency by re-implementing show dependencies
Superseder Nosy List bf, ganesh, raichoo
Related Issues
Status accepted Assigned To ganesh
Milestone

Created on 2020-01-27.21:00:00 by bf, last changed 2020-02-27.20:29:07 by ganesh.

Files
File name Status Uploaded Type Edit Remove
dependencies.png raichoo, 2020-02-09.11:37:15 image/png
fix_-need-to-quote-hashes-in-dot-output.dpatch bf, 2020-02-09.21:17:26 application/x-darcs-patch
move-getdeps-and-spatchanddeps-from-d_p_depends-to-d_ui_c_showdependencies.dpatch bf, 2020-01-27.20:59:59 application/x-darcs-patch
move-getdeps-and-spatchanddeps-from-d_p_depends-to-d_ui_c_showdependencies.dpatch bf, 2020-01-28.21:39:32 application/x-darcs-patch
pEpkey.asc bf, 2020-02-09.21:12:05 application/pgp-keys
patch-preview.txt bf, 2020-01-27.20:59:59 text/x-darcs-patch
patch-preview.txt bf, 2020-01-28.21:39:32 text/x-darcs-patch
patch-preview.txt bf, 2020-02-09.21:17:26 text/x-darcs-patch
unnamed bf, 2020-01-27.20:59:59 text/plain
unnamed bf, 2020-01-28.21:39:32 text/plain
unnamed bf, 2020-02-09.21:17:26 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg21752 (view) Author: bf Date: 2020-01-27.20:59:59
Following up one making 'show dependencies' optional.

1 patch for repository http://darcs.net/screened:

patch 4c36c4c72ce4d0d1361b64d3737f7a7a7ed83708
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Jan 27 15:39:08 CET 2020
  * move getDeps and SPatchAndDeps from D.P.Depends to D.UI.C.ShowDependencies
  
  This somewhat messy code has no relationship with anything else happening
  inside D.P.Depends. Besides, getting rid of the graphviz dependency may
  involve re-writing at least parts of that code, which will be easier if it
  is concentrated in D.UI.C.ShowDependencies.
Attachments
msg21760 (view) Author: bf Date: 2020-01-28.21:39:32
It was surprisingly easy to re-implement the main functionality from first
principles. I also find it remarkable how much cleaner the code has become.
The output of the new 'show dependencies' command differs in two points: it
uses a hex rendering of the shortened (to 32 bits) patch ID as the node
identifier. It also contains edges for all direct dependencies which I find
more useful than reducing the graph to avoid transitive edges by arbitrarily
deleting them.

2 patches for repository http://darcs.net/screened:

patch 4c36c4c72ce4d0d1361b64d3737f7a7a7ed83708
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Jan 27 15:39:08 CET 2020
  * move getDeps and SPatchAndDeps from D.P.Depends to D.UI.C.ShowDependencies
  
  This somewhat messy code has no relationship with anything else happening
  inside D.P.Depends. Besides, getting rid of the graphviz dependency may
  involve re-writing at least parts of that code, which will be easier if it
  is concentrated in D.UI.C.ShowDependencies.

patch 3a8e57ef9fed776f62a3538f8842b6593546e368
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Jan 28 22:37:44 CET 2020
  * remove graphviz dependency by re-implementing show dependencies
Attachments
msg21777 (view) Author: raichoo Date: 2020-02-09.11:37:15
I'm having some issues interpreting the show dependencies output of this log.

It looks like the `re-enable XWayland support` depends on the `use `pkg-config` to locate wayland protocol files` twice since 
`409bbad0ff6955c4fa9bda58ccda123e58dc103b` is also the hash of that patch. 
patch eaeab0643fa1c7df014fc781293ff644b3fa4828
Author: raichoo@acmelabs.space
Date:   Fri Feb  7 22:18:23 CET 2020
  * re-enable XWayland support
  
  XWayland support has not been maintained for quite a while so we need to make it
  work in the new infrastructure. This patch introduces the view method `move_resize`
  which allows to move and resize a view atomically, this is needed for properly
  handling XWayland views.

patch a282380414bd498de8428bfdfc3cf510367adc40
Author: raichoo@acmelabs.space
Date:   Fri Feb  7 20:09:27 CET 2020
  * fix indicator damage on maximize
  
  When views are small enough so that their damage does not cover the indicator
  the latter can leave artifacts.

patch 409bbad0ff6955c4fa9bda58ccda123e58dc103b
Author: raichoo@acmelabs.space
Date:   Fri Feb  7 13:34:33 CET 2020
  * use `pkg-config` to locate wayland protocol files

patch 417a707301b75d99f796dd508edbde87f5c0fb7a
Author: raichoo@acmelabs.space
Date:   Thu Feb  6 21:47:16 CET 2020
  * clarify hikari support

patch 15a7a6359d76fa54f59e4fd0704a4986d4352f2d
Author: raichoo@acmelabs.space
Date:   Thu Feb  6 20:59:16 CET 2020
  tagged 1.0.0-alpha2
Attachments
msg21778 (view) Author: bf Date: 2020-02-09.21:12:05
Oops. I did not realize that the patch hashes need to be quoted to be
valid node identifiers in the dot language. Will fix.
Attachments
msg21779 (view) Author: bf Date: 2020-02-09.21:17:26
1 patch for repository http://darcs.net/screened:

patch 1fb9819b0d237af77f07387c98b95d59d758dc98
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Feb  9 22:28:09 CET 2020
  * fix: need to quote hashes in dot output
Attachments
msg21824 (view) Author: ganesh Date: 2020-02-15.20:29:55
raichoo, is this working ok for you now?
msg21855 (view) Author: ganesh Date: 2020-02-18.18:08:49
I confirmed with raichoo on IRC that it's good now.
msg21856 (view) Author: raichoo Date: 2020-02-18.20:40:57
Yeah, sorry. Your reply got lost in my overflowing inbox :/
msg21922 (view) Author: ganesh Date: 2020-02-26.06:56:28
The code looks reasonable. I'm a bit surprised we don't have any tests
of the output, but that was already the case before your changes.
History
Date User Action Args
2020-01-27 21:00:00bfcreate
2020-01-28 21:39:33bfsetfiles: + patch-preview.txt, move-getdeps-and-spatchanddeps-from-d_p_depends-to-d_ui_c_showdependencies.dpatch, unnamed
messages: + msg21760
title: move getDeps and SPatchAndDeps from D.P.Depends to D.U... -> : remove graphviz dependency by re-implementing show dependencies
2020-01-29 08:09:25bfsettitle: : remove graphviz dependency by re-implementing show dependencies -> remove graphviz dependency by re-implementing show dependencies
2020-01-29 08:13:57bfsetstatus: needs-screening -> needs-review
2020-02-09 11:37:16raichoosetfiles: + dependencies.png
messages: + msg21777
2020-02-09 21:12:05bfsetfiles: + pEpkey.asc
messages: + msg21778
2020-02-09 21:17:26bfsetfiles: + patch-preview.txt, fix_-need-to-quote-hashes-in-dot-output.dpatch, unnamed
messages: + msg21779
2020-02-15 20:29:55ganeshsetstatus: needs-review -> review-in-progress
nosy: + raichoo, ganesh
messages: + msg21824
assignedto: ganesh
2020-02-18 18:08:49ganeshsetmessages: + msg21855
2020-02-18 20:40:57raichoosetmessages: + msg21856
2020-02-26 06:56:29ganeshsetstatus: review-in-progress -> accepted-pending-tests
messages: + msg21922
2020-02-27 20:29:07ganeshsetstatus: accepted-pending-tests -> accepted