Patch 1993: use more efficient filename format for V3 - Darcs bug tracker

Title	use more efficient filename format for V3
Superseder		Nosy List	bfrk
Related Issues
Status	in-discussion	Assigned To
Milestone

Created on 2020-02-17.08:49:59 by bfrk, last changed 2020-02-21.18:40:32 by bfrk.

Files
File name	Status	Uploaded	Type	Edit	Remove
pEpkey.asc		bfrk, 2020-02-17.10:49:25	application/pgp-keys
patch-preview.txt		bfrk, 2020-02-17.08:49:58	text/x-darcs-patch
unnamed		bfrk, 2020-02-17.08:49:58	text/plain
use-more-efficient-filename-format-for-v3.dpatch		bfrk, 2020-02-17.08:49:58	application/x-darcs-patch

See mailing list archives for discussion on individual patches.

Messages
msg21849 (view)	Author: bfrk	Date: 2020-02-17.08:49:58
This is mostly for discussion at this time. I did some profiling to find out why certain darcs commands take quite a long time before they present a patch. For instance, in screened, 'echo nn \| darcs rollback GNUmakefile' takes a few seconds to run. This is basically an algorithmic problem, not related to low-level parsing efficiency. However, I found that after eliminating some of the algorithmic problems, it appears that the white space decoding is responsible for more than half of the runtime. 1 patch for repository http://darcs.net/screened: patch 26a286fe0186affba09e79c52e5b281418d41cc5 Author: Ben Franksen <ben.franksen@online.de> Date: Sat Feb 15 20:30:32 CET 2020 * use more efficient filename format for V3 It now prefixes each filename with its length in bytes and then stores the raw byte string. This avoids any need for encoding white space. The output of darcs commands is not affected except when the infamous --machine-readable option is in effect. Attachments patch-preview.txt unnamed use-more-efficient-filename-format-for-v3.dpatch
msg21850 (view)	Author: bfrk	Date: 2020-02-17.10:49:25
I cannot reproduce my profiling results, so for the moment ignore this. Attachments pEpkey.asc

History
Date	User	Action	Args
2020-02-17 08:49:59	bfrk	create
2020-02-17 10:49:25	bfrk	set	files: + pEpkey.asc messages: + msg21850
2020-02-21 18:40:32	bfrk	set	status: needs-screening -> in-discussion