darcs

Patch 1995 accept issue2640: darcs rollback filename: no patches ...

Title accept issue2640: darcs rollback filename: no patches ...
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To
Milestone

Created on 2020-02-18.08:46:41 by bfrk, last changed 2020-07-19.09:05:01 by ganesh.

Files
File name Status Uploaded Type Edit Remove
accept-issue2640_-darcs-rollback-filename_-no-patches-selected.dpatch bfrk, 2020-02-18.08:46:40 application/x-darcs-patch
fix-description-in-test-for-issue2640.dpatch bfrk, 2020-02-18.09:59:52 application/x-darcs-patch
fix_-mark-test-for-issue2640-as-failing.dpatch bfrk, 2020-02-20.10:01:43 application/x-darcs-patch
pEpkey.asc bfrk, 2020-02-20.09:56:54 application/pgp-keys
patch-preview.txt bfrk, 2020-02-18.08:46:40 text/x-darcs-patch
patch-preview.txt bfrk, 2020-02-18.09:59:52 text/x-darcs-patch
patch-preview.txt bfrk, 2020-02-20.10:01:43 text/x-darcs-patch
unnamed bfrk, 2020-02-18.08:46:40 text/plain
unnamed bfrk, 2020-02-18.09:59:52 text/plain
unnamed bfrk, 2020-02-20.10:01:43 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg21853 (view) Author: bfrk Date: 2020-02-18.08:46:40
1 patch for repository http://darcs.net/screened:

patch f258403b86189c67e7157c165b1255012634e33c
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Feb 18 08:43:25 CET 2020
  * accept issue2640: darcs rollback filename: no patches selected
Attachments
msg21854 (view) Author: bfrk Date: 2020-02-18.09:59:52
1 patch for repository http://darcs.net/screened:

patch 5916e51893dfb92db483a7d9aa6e7c4aaa664b7d
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Feb 18 10:57:28 CET 2020
  * fix description in test for issue2640
Attachments
msg21860 (view) Author: ganesh Date: 2020-02-20.06:42:07
You've added a "live" (not failing) test but I don't see any patch
to fix the problem - am I missing something? It's actually failing
for me on Windows. Just wanted to check if you made a mistake before
I start debugging if it's a Windows-specific problem.
msg21862 (view) Author: bfrk Date: 2020-02-20.09:56:54
Sorry about that. I saw a lot of issue-related tests in rollback.sh and
added the new one there without thinking that this will disrupt our
processes. Will fix.
Attachments
msg21863 (view) Author: bfrk Date: 2020-02-20.10:01:43
1 patch for repository http://darcs.net/screened:

patch f6caccefb8780a2b41cc208afc3aa222314a8d88
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Feb 20 10:59:02 CET 2020
  * fix: mark test for issue2640 as failing
Attachments
msg22176 (view) Author: ganesh Date: 2020-07-18.23:53:32
Looks fine.
History
Date User Action Args
2020-02-18 08:46:41bfrkcreate
2020-02-18 08:48:03bfrksetstatus: needs-screening -> needs-review
2020-02-18 09:59:53bfrksetfiles: + patch-preview.txt, fix-description-in-test-for-issue2640.dpatch, unnamed
messages: + msg21854
2020-02-20 06:42:07ganeshsetmessages: + msg21860
2020-02-20 09:56:54bfrksetfiles: + pEpkey.asc
messages: + msg21862
2020-02-20 10:01:44bfrksetfiles: + patch-preview.txt, fix_-mark-test-for-issue2640-as-failing.dpatch, unnamed
messages: + msg21863
2020-07-18 23:53:33ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg22176
2020-07-19 09:05:01ganeshsetstatus: accepted-pending-tests -> accepted