darcs

Patch 2000 Setup.hs: allow use of darcs as a cabal subproject

Title Setup.hs: allow use of darcs as a cabal subproject
Superseder Nosy List bf
Related Issues
Status rejected Assigned To
Milestone

Created on 2020-02-22.06:52:09 by bf, last changed 2020-02-23.20:48:22 by bf.

Files
File name Status Uploaded Type Edit Remove
pEpkey.asc bf, 2020-02-23.20:48:04 application/pgp-keys
patch-preview.txt bf, 2020-02-22.06:52:09 text/x-darcs-patch
setup_hs_-allow-use-of-darcs-as-a-cabal-subproject_0.dpatch bf, 2020-02-22.06:52:09 application/x-darcs-patch
unnamed bf, 2020-02-22.06:52:09 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg21871 (view) Author: bf Date: 2020-02-22.06:52:09
This is for branch-2.14. It is a simplified version of 

patch 592492b6b0ca524cf154ede4fcb0b902eb596ad0
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Feb 12 12:58:10 CET 2020
  * fix manpage generation in Setup.hs and clean up imports

that cleanly applies to this branch. This makes it easier to build darcsden
against darcs-2.14.

I would like to push it, but I am not confident to do so without your
approval.

1 patch for repository http://darcs.net/releases/branch-2.14:

patch 7f9e8d76769e21fde94395a06d2b2a99cb57b5dc
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Feb 19 09:45:56 CET 2020
  * Setup.hs: allow use of darcs as a cabal subproject
  
  Creation and later installation of the man page make sense only if we build
  a darcs executable. When darcs is used as a cabal subproject, only the
  library is built. So when building we check that we have a darcs exe and
  when installing we check that the manpage is actually there.
Attachments
msg21889 (view) Author: ganesh Date: 2020-02-23.13:34:32
I can't see any obvious issue with the strategy, though I haven't
tested it myself. I think you should go ahead (and one of us
should do a release to hackage) and if it doesn't work out we
can always release a new version.
msg21891 (view) Author: bf Date: 2020-02-23.20:48:04
> I can't see any obvious issue with the strategy, though I haven't 
> tested it myself. I think you should go ahead (and one of us should
> do a release to hackage) and if it doesn't work out we can always
> release a new version.

There is not much point in making a release and uploading that to
hackage. Because if you install darcs using cabal like any other
dependency, then there is no problem with Setup.hs. Indeed I have tried
to build my updated darcsden fork against darcs-2.14.2 in the default
way (i.e. without having a local copy of the darcs sources inside the
darcsden tree) and that works just fine.

But this also means that my patch doesn't make much sense for the
branch-2.14. There is no need to compile against a clone of branch-2.14
if the released darcs-2.14.2 that cabal finds and uses by default works
perfectly well as a dependency.

I'll mark this patch as rejected.
Attachments
History
Date User Action Args
2020-02-22 06:52:09bfcreate
2020-02-23 13:34:32ganeshsetmessages: + msg21889
2020-02-23 20:48:04bfsetfiles: + pEpkey.asc
messages: + msg21891
2020-02-23 20:48:22bfsetstatus: needs-screening -> rejected